Bug 121218 - [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
Summary: [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2013-09-12 02:00 PDT by Carlos Garcia Campos
Modified: 2013-09-12 03:53 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.14 KB, patch)
2013-09-12 02:05 PDT, Carlos Garcia Campos 		pnormand: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-09-12 02:00:12 PDT 
It simply does nothing. This is because skipping the entire suite was added to skip tests when they can't be run because of the environment, for example to skip the a11y tests when the at-spi daemons fail to start. However, some tests have been skipped entirely lately because they fail or timeout under xvfb, but the script now allows to run tests without xvfb. I think we should disable tests that are impossible to run because of the environment instead of skipping them, and make skip options work with all skipped tests.
Comment 1 Carlos Garcia Campos 2013-09-12 02:05:12 PDT 
Created attachment 211408 [details]
Patch
Comment 2 Carlos Garcia Campos 2013-09-12 03:53:57 PDT 
Committed r155605: <http://trac.webkit.org/changeset/155605>