Bug 121209 - XMLSerializer.serializeToString() should throw exception for invalid node value.
Summary: XMLSerializer.serializeToString() should throw exception for invalid node value.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vivek Galatage
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-09-11 21:23 PDT by Vivek Galatage
Modified: 2019-02-06 09:02 PST (History)
3 users (show)

See Also:

Attachments
Patch (8.56 KB, patch)
2013-09-11 21:29 PDT, Vivek Galatage 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vivek Galatage 2013-09-11 21:23:45 PDT 
XMLSerializer.serializeToString() should throw exception for invalid node value.

FF and Opera 12 (pre blink/webkit) throw exception in case the node value is invalid.
Blink sends an empty string as the result of serializeToString operation with invalid node.
We should match with other browsers for throwing it as an exception.

Blink review URL: https://chromiumcodereview.appspot.com/23532055/

Patch follows.
Comment 1 Vivek Galatage 2013-09-11 21:29:14 PDT 
Created attachment 211392 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-12 07:40:52 PDT 
Comment on attachment 211392 [details]
Patch

Clearing flags on attachment: 211392

Committed r155609: <http://trac.webkit.org/changeset/155609>
Comment 3 WebKit Commit Bot 2013-09-12 07:40:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Lucas Forschler 2019-02-06 09:02:38 PST 
Mass moving XML DOM bugs to the "DOM" Component.