We have three globals in this file. Encapsulate them inside a class in the preparation to fix the bug 121199.
Created attachment 211390 [details] Cleanup
Comment on attachment 211390 [details] Cleanup Attachment 211390 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1797027
Comment on attachment 211390 [details] Cleanup Attachment 211390 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1830028
Comment on attachment 211390 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=211390&action=review > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1086 > + map->ensurePropertyMap(); // FIXME: ensurePropertyMap() calls instance() inside addShorthandProperties(). initialize() might be a better name. We usually use ensure* for functions that return a value.
Committed r155647: <http://trac.webkit.org/changeset/155647>
(In reply to comment #4) > (From update of attachment 211390 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211390&action=review > > > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1086 > > + map->ensurePropertyMap(); // FIXME: ensurePropertyMap() calls instance() inside addShorthandProperties(). > > initialize() might be a better name. We usually use ensure* for functions that return a value. I'm getting rid of this function in the bug 121199.