Bug 121205 - Encapsulate globals in CSSPropertyAnimation.cpp
Summary: Encapsulate globals in CSSPropertyAnimation.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 121199
  Show dependency treegraph
 
Reported: 2013-09-11 19:43 PDT by Ryosuke Niwa
Modified: 2013-09-12 14:19 PDT (History)
12 users (show)

See Also:


Attachments
Cleanup (13.70 KB, patch)
2013-09-11 19:56 PDT, Ryosuke Niwa
koivisto: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-09-11 19:43:01 PDT
We have three globals in this file. Encapsulate them inside a class in the preparation to fix the bug 121199.
Comment 1 Ryosuke Niwa 2013-09-11 19:56:30 PDT
Created attachment 211390 [details]
Cleanup
Comment 2 Early Warning System Bot 2013-09-11 20:04:37 PDT
Comment on attachment 211390 [details]
Cleanup

Attachment 211390 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1797027
Comment 3 Early Warning System Bot 2013-09-11 20:08:50 PDT
Comment on attachment 211390 [details]
Cleanup

Attachment 211390 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1830028
Comment 4 Antti Koivisto 2013-09-12 09:26:17 PDT
Comment on attachment 211390 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=211390&action=review

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1086
> +            map->ensurePropertyMap(); // FIXME: ensurePropertyMap() calls instance() inside addShorthandProperties().

initialize() might be a better name. We usually use ensure* for functions that return a value.
Comment 5 Ryosuke Niwa 2013-09-12 13:51:08 PDT
Committed r155647: <http://trac.webkit.org/changeset/155647>
Comment 6 Ryosuke Niwa 2013-09-12 14:19:54 PDT
(In reply to comment #4)
> (From update of attachment 211390 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211390&action=review
> 
> > Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1086
> > +            map->ensurePropertyMap(); // FIXME: ensurePropertyMap() calls instance() inside addShorthandProperties().
> 
> initialize() might be a better name. We usually use ensure* for functions that return a value.

I'm getting rid of this function in the bug 121199.