Bug 121194 - Removed some unused functions from the debugger interface
Summary: Removed some unused functions from the debugger interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-11 17:34 PDT by Geoffrey Garen
Modified: 2013-09-11 20:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.66 KB, patch)
2013-09-11 17:36 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (13.21 KB, patch)
2013-09-11 17:40 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (16.20 KB, patch)
2013-09-11 17:43 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (17.39 KB, patch)
2013-09-11 17:46 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (26.88 KB, patch)
2013-09-11 19:30 PDT, Geoffrey Garen 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2013-09-11 17:34:29 PDT 
Removed some unused functions from the debugger interface
Comment 1 Geoffrey Garen 2013-09-11 17:36:56 PDT 
Created attachment 211369 [details]
Patch
Comment 2 Geoffrey Garen 2013-09-11 17:40:15 PDT 
Created attachment 211370 [details]
Patch
Comment 3 Geoffrey Garen 2013-09-11 17:43:44 PDT 
Created attachment 211371 [details]
Patch
Comment 4 Geoffrey Garen 2013-09-11 17:46:39 PDT 
Created attachment 211373 [details]
Patch
Comment 5 Geoffrey Garen 2013-09-11 18:13:34 PDT 
Comment on attachment 211373 [details]
Patch

Looks like I need to update a layout tests. Stay tuned...
Comment 6 Timothy Hatcher 2013-09-11 18:14:02 PDT 
Comment on attachment 211373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211373&action=review

> Source/WebCore/inspector/InjectedScript.cpp:-101
> -    ScriptFunctionCall function(injectedScriptObject(), "restartFrame");

restartFrame can be removed from InjectedScriptSource.js too.

> Source/WebCore/inspector/InjectedScript.cpp:-121
> -    ScriptFunctionCall function(injectedScriptObject(), "setVariableValue");

setVariableValue can be removed from InjectedScriptSource.js too.
Comment 7 Geoffrey Garen 2013-09-11 19:30:12 PDT 
Created attachment 211387 [details]
Patch
Comment 8 Joseph Pecoraro 2013-09-11 19:39:52 PDT 
Comment on attachment 211387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211387&action=review

r=me

> Source/WebCore/inspector/InjectedScriptSource.js:-692
> -            setter = InjectedScriptHost.setFunctionVariableValue.bind(InjectedScriptHost, func); 

This is the only user of InjectedScriptHost.setFunctionVariableValue.bind. It is equally stubbed so you can remove that too!

  - WebCore/bindings/js/JSInjectedScriptHostCustom.cpp stub
  - WebCore/inspector/InjectedScriptExterns.js stub
  - WebCore/inspector/InjectedScriptHost.idl [Custom]
Comment 9 Geoffrey Garen 2013-09-11 20:07:21 PDT 
Committed r155589: <http://trac.webkit.org/changeset/155589>
Comment 10 Geoffrey Garen 2013-09-11 20:08:01 PDT 
Thanks!