Bug 121187 - [CSS Shapes] Turn shape's logicalwidth/height into a LayoutSize
Summary: [CSS Shapes] Turn shape's logicalwidth/height into a LayoutSize
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 89256
  Show dependency tree / graph
 
Reported: 2013-09-11 15:45 PDT by Zoltan Horvath
Modified: 2013-09-12 13:44 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (4.02 KB, patch)
2013-09-11 15:51 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
proposed patch (4.38 KB, patch)
2013-09-11 16:12 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-09-11 15:45:06 PDT 
Turn shape's logicalwidth/height into a LayoutSize
Comment 1 Zoltan Horvath 2013-09-11 15:51:34 PDT 
Created attachment 211360 [details]
proposed patch
Comment 2 Zoltan Horvath 2013-09-11 16:12:08 PDT 
Created attachment 211362 [details]
proposed patch
Comment 3 Dave Hyatt 2013-09-12 09:26:58 PDT 
Comment on attachment 211362 [details]
proposed patch

r=me
Comment 4 Dave Hyatt 2013-09-12 09:27:33 PDT 
Comment on attachment 211362 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211362&action=review

> Source/WebCore/rendering/shapes/ShapeInfo.h:99
> +    LayoutUnit shapeContainingBlockHeight() const { return (m_renderer->style()->boxSizing() == CONTENT_BOX) ? (m_shapeLogicalSize.height() + m_renderer->borderAndPaddingLogicalHeight()) : m_shapeLogicalSize.height(); }

Just an observation for a future patch, but this should really be shapeContainingBockLogicalHeight().
Comment 5 WebKit Commit Bot 2013-09-12 09:48:41 PDT 
Comment on attachment 211362 [details]
proposed patch

Clearing flags on attachment: 211362

Committed r155626: <http://trac.webkit.org/changeset/155626>
Comment 6 WebKit Commit Bot 2013-09-12 09:48:43 PDT 
All reviewed patches have been landed.  Closing bug.