Bug 121184 - REGRESSION (r155561): extract-localizable-strings can miss strings
Summary: REGRESSION (r155561): extract-localizable-strings can miss strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-11 14:54 PDT by mitz
Modified: 2013-09-11 15:06 PDT (History)
3 users (show)

See Also:


Attachments
Don’t discard lines while waiting for ) or ] (1.09 KB, patch)
2013-09-11 14:54 PDT, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-09-11 14:54:11 PDT
Created attachment 211355 [details]
Don’t discard lines while waiting for ) or ]

I didn’t notice that I’d introduced this bug because it doesn’t affect any of the files update-webkit-localizable-strings processes.
Comment 1 WebKit Commit Bot 2013-09-11 15:05:20 PDT
Attachment 211355 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/extract-localizable-strings']" exit_code: 1
Tools/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 mitz 2013-09-11 15:06:32 PDT
Fixed in <http://trac.webkit.org/r155568>.