Bug 121178 - update-webkit-localizable-strings is at least 5.8x slower than it should be
Summary: update-webkit-localizable-strings is at least 5.8x slower than it should be
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-11 12:43 PDT by mitz
Modified: 2013-09-11 14:02 PDT (History)
3 users (show)

See Also:

Attachments
Make update-webkit-localizable-strings 5.8x faster (1.31 KB, patch)
2013-09-11 12:59 PDT, mitz 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-09-11 12:43:08 PDT 
update-webkit-localizable-strings is at least 5.8x slower than it should be
Comment 1 mitz 2013-09-11 12:59:53 PDT 
Created attachment 211342 [details]
Make update-webkit-localizable-strings 5.8x faster
Comment 2 Darin Adler 2013-09-11 13:56:39 PDT 
There are lots of tricks to make regular expressions faster in perl. For example, I think non-capturing parentheses are faster, and maybe two separate regular expressions might be faster than then using “|”.
Comment 3 mitz 2013-09-11 14:02:14 PDT 
Fixed in <http://trac.webkit.org/r155561>.