WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 121176
HTMLEntityTable could use char to reduce binary size
https://bugs.webkit.org/show_bug.cgi?id=121176
Summary
HTMLEntityTable could use char to reduce binary size
Simon Fraser (smfr)
Reported
2013-09-11 12:19:42 PDT
static const UChar zwnjSemicolonEntityName[] = {'z', 'w', 'n', 'j', ';'}; static const HTMLEntityTableEntry staticEntityTable[2231] = { { AEligEntityName, 5, 0x000C6, 0 }, Pretty sure we could use char to save space. Symbols says: 0x0000000000eada30 ( 0xd130) WebCore::(anonymous namespace)::staticEntityTable [NameNList, MangledNameNList, NList] 0x0000000000d6cc30 ( 0xa) WebCore::(anonymous namespace)::AEligEntityName [NameNList, MangledNameNList, NList] etc.
Attachments
Fixes the bug
(3.40 KB, patch)
2013-09-11 12:41 PDT
,
Ryosuke Niwa
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2013-09-11 12:32:37 PDT
Let's fix this.
Ryosuke Niwa
Comment 2
2013-09-11 12:41:30 PDT
Created
attachment 211340
[details]
Fixes the bug
Ryosuke Niwa
Comment 3
2013-09-11 13:45:55 PDT
Committed
r155559
: <
http://trac.webkit.org/changeset/155559
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug