Bug 121172 – Stop using deleteAllValues in SVG code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Stop using deleteAllValues in SVG code

[Anders Carlsson]

Created attachment 211333 [details]
Patch

[Anders Carlsson]

Committed r155547: <http://trac.webkit.org/changeset/155547>

[Anders Carlsson]

Committed r155552: <http://trac.webkit.org/changeset/155552>

[Darin Adler]

Comment on attachment 211333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211333&action=review

> Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp:150
> +        m_clipper.set(object, createOwned<ClipperData>().release());

Why release() instead of std::move?

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:219
> +        m_filter.set(object, filterData.release());

Same question.

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:233
> +        m_filter.set(object, filterData.release());

Same question.Same question.

> Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:249
> +    m_filter.set(object, filterData.release());

Same question.Same question.

> Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:77
> +        m_masker.set(object, createOwned<MaskerData>().release());

Same question.

[Anders Carlsson]

(In reply to comment #4)
> (From update of attachment 211333 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211333&action=review
> 
> > Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp:150
> > +        m_clipper.set(object, createOwned<ClipperData>().release());
> 
> Why release() instead of std::move?
> 

Because you can’t currently pass a move-only type as a value to HashMap. We work around this with PassOwnPtr by using the pass traits.

I hope that once we make our other collections work with move-only types we’ll be able to get rid of the pass traits.