Bug 121171 - Remove TimelineTraceEventProcessor since no current ports use it
Summary: Remove TimelineTraceEventProcessor since no current ports use it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-11 11:19 PDT by Timothy Hatcher
Modified: 2013-09-11 11:58 PDT (History)
3 users (show)

See Also:

Attachments
Patch (36.25 KB, patch)
2013-09-11 11:20 PDT, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-09-11 11:19:36 PDT 
Remove TimelineTraceEventProcessor since no current ports use it
Comment 1 Timothy Hatcher 2013-09-11 11:20:08 PDT 
Created attachment 211330 [details]
Patch
Comment 2 Joseph Pecoraro 2013-09-11 11:34:10 PDT 
Comment on attachment 211330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211330&action=review

r=me

> Source/WebCore/inspector/TimelineTraceEventProcessor.cpp:-167
> -    registerHandler(InstrumentationEvents::BeginFrame, TracePhaseInstant, &TimelineTraceEventProcessor::onBeginFrame);
> -    registerHandler(InstrumentationEvents::PaintLayer, TracePhaseBegin, &TimelineTraceEventProcessor::onPaintLayerBegin);
> -    registerHandler(InstrumentationEvents::PaintLayer, TracePhaseEnd, &TimelineTraceEventProcessor::onPaintLayerEnd);
> -    registerHandler(InstrumentationEvents::RasterTask, TracePhaseBegin, &TimelineTraceEventProcessor::onRasterTaskBegin);
> -    registerHandler(InstrumentationEvents::RasterTask, TracePhaseEnd, &TimelineTraceEventProcessor::onRasterTaskEnd);
> -    registerHandler(InstrumentationEvents::Layer, TracePhaseDeleteObject, &TimelineTraceEventProcessor::onLayerDeleted);
> -    registerHandler(InstrumentationEvents::Paint, TracePhaseInstant, &TimelineTraceEventProcessor::onPaint);

I think this was the only user of InstrumentationEvents and InstrumentationEventArguments. You can remove the enum / strings in InspectorInstrumentation.*:

    inspector/InspectorInstrumentation.cpp
    1390:namespace InstrumentationEvents {
    1398:namespace InstrumentationEventArguments {

    inspector/InspectorInstrumentation.h
    515:namespace InstrumentationEvents {
    523:namespace InstrumentationEventArguments {
Comment 3 Timothy Hatcher 2013-09-11 11:58:57 PDT 
http://trac.webkit.org/changeset/155549