WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
121170
RenderTextTrackContainerElement::layout() pretends to have done the layout, but postpones the work on a 0-delay timer
https://bugs.webkit.org/show_bug.cgi?id=121170
Summary
RenderTextTrackContainerElement::layout() pretends to have done the layout, b...
Alexey Proskuryakov
Reported
2013-09-11 11:03:20 PDT
This causes flakiness on at least one test (
bug 121169
), and I expect this to be a general issue that affects many tests. Perhaps most of these are already marked as flaky or skipped. RenderTextTrackContainerElement::layout() calls MediaControlTextTrackContainerElement::updateSizes(), which does some work, and delays other work on a zero delay timer! So by the time layout is done, text cue sizes are still wrong, they are only updated in updateTimerFired(). This zero delay timer cannot be simply removed, because it does a lot of work that's unsafe during layout, including DOM manipulation. While I don't know much about text tracks and/or layout, I have a strong feeling that it must be possible to do it differently.
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2013-09-11 11:03:42 PDT
<
rdar://problem/14966387
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug