RESOLVED FIXED 121167
MapData and WeakMapData don't need to be objects 
https://bugs.webkit.org/show_bug.cgi?id=121167
Summary MapData and WeakMapData don't need to be objects
Sam Weinig
Reported 2013-09-11 10:24:03 PDT
MapData and WeakMapData don't need to be objects
Attachments
Patch (19.57 KB, patch)
2013-09-11 10:44 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-09-11 10:44:23 PDT
Created attachment 211327 [details] Patch
Sam Weinig
Comment 2 2013-09-11 10:52:01 PDT
This will help with implementing the update Promises spec (120954).
Geoffrey Garen
Comment 3 2013-09-11 12:32:09 PDT
Comment on attachment 211327 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211327&action=review Nice! > Source/JavaScriptCore/runtime/MapData.h:82 > + static const bool needsDestruction = true; > + static const bool hasImmortalStructure = true; I wonder if we should make a JSDestructibleCell base class, to make this easier in general.
Sam Weinig
Comment 4 2013-09-11 13:07:47 PDT
(In reply to comment #3) > (From update of attachment 211327 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211327&action=review > > Nice! > > > Source/JavaScriptCore/runtime/MapData.h:82 > > + static const bool needsDestruction = true; > > + static const bool hasImmortalStructure = true; > > I wonder if we should make a JSDestructibleCell base class, to make this easier in general. Might make sense. I'll look into to that.
WebKit Commit Bot
Comment 5 2013-09-11 13:33:11 PDT
Comment on attachment 211327 [details] Patch Clearing flags on attachment: 211327 Committed r155558: <http://trac.webkit.org/changeset/155558>
WebKit Commit Bot
Comment 6 2013-09-11 13:33:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.