Bug 121167 - MapData and WeakMapData don't need to be objects
Summary: MapData and WeakMapData don't need to be objects
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks: 120954
  Show dependency treegraph
 
Reported: 2013-09-11 10:24 PDT by Sam Weinig
Modified: 2013-09-11 13:33 PDT (History)
1 user (show)

See Also:


Attachments
Patch (19.57 KB, patch)
2013-09-11 10:44 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-09-11 10:24:03 PDT
MapData and WeakMapData don't need to be objects
Comment 1 Sam Weinig 2013-09-11 10:44:23 PDT
Created attachment 211327 [details]
Patch
Comment 2 Sam Weinig 2013-09-11 10:52:01 PDT
This will help with implementing the update Promises spec (120954).
Comment 3 Geoffrey Garen 2013-09-11 12:32:09 PDT
Comment on attachment 211327 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211327&action=review

Nice!

> Source/JavaScriptCore/runtime/MapData.h:82
> +    static const bool needsDestruction = true;
> +    static const bool hasImmortalStructure = true;

I wonder if we should make a JSDestructibleCell base class, to make this easier in general.
Comment 4 Sam Weinig 2013-09-11 13:07:47 PDT
(In reply to comment #3)
> (From update of attachment 211327 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211327&action=review
> 
> Nice!
> 
> > Source/JavaScriptCore/runtime/MapData.h:82
> > +    static const bool needsDestruction = true;
> > +    static const bool hasImmortalStructure = true;
> 
> I wonder if we should make a JSDestructibleCell base class, to make this easier in general.

Might make sense.  I'll look into to that.
Comment 5 WebKit Commit Bot 2013-09-11 13:33:11 PDT
Comment on attachment 211327 [details]
Patch

Clearing flags on attachment: 211327

Committed r155558: <http://trac.webkit.org/changeset/155558>
Comment 6 WebKit Commit Bot 2013-09-11 13:33:13 PDT
All reviewed patches have been landed.  Closing bug.