RESOLVED FIXED 121149
[ATK] Adds mapping MenuItemRadioRole to ATK
https://bugs.webkit.org/show_bug.cgi?id=121149
Summary [ATK] Adds mapping MenuItemRadioRole to ATK
Krzysztof Czech
Reported 2013-09-11 02:41:16 PDT
MenuItemRadioRole is a new AccessibilityRole that appeared after r155492. I'm adding mapping to ATK.
Attachments
Patch (5.42 KB, patch)
2013-09-11 02:52 PDT, Krzysztof Czech
mario: review+
mario: commit-queue-
Patch (5.20 KB, patch)
2013-09-11 03:24 PDT, Krzysztof Czech
no flags
Radar WebKit Bug Importer
Comment 1 2013-09-11 02:41:27 PDT
Krzysztof Czech
Comment 2 2013-09-11 02:52:43 PDT
Mario Sanchez Prada
Comment 3 2013-09-11 03:10:09 PDT
Comment on attachment 211292 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211292&action=review Looks good to me, but there's an extra line that should be removed before landing > LayoutTests/ChangeLog:11 > + * platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Thanks for adding the GTK expectation > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:234 > + Wrong extra line
Krzysztof Czech
Comment 4 2013-09-11 03:24:51 PDT
Krzysztof Czech
Comment 5 2013-09-11 03:25:55 PDT
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:234 > > + > > Wrong extra line Indeed, ups. Already corrected.
WebKit Commit Bot
Comment 6 2013-09-11 04:30:14 PDT
Comment on attachment 211294 [details] Patch Clearing flags on attachment: 211294 Committed r155518: <http://trac.webkit.org/changeset/155518>
WebKit Commit Bot
Comment 7 2013-09-11 04:30:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.