Bug 121132 - Propagate the Int48 stuff into the prediction propagator.
Summary: Propagate the Int48 stuff into the prediction propagator.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 121064
  Show dependency tree / graph
 
Reported: 2013-09-10 16:37 PDT by Filip Pizlo
Modified: 2013-09-10 21:34 PDT (History)
9 users (show)

See Also:

Attachments
the patch (13.18 KB, patch)
2013-09-10 16:38 PDT, Filip Pizlo 		mhahnenberg: review+
gtk-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-10 16:37:12 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-09-10 16:38:39 PDT 
Created attachment 211263 [details]
the patch
Comment 2 Mark Hahnenberg 2013-09-10 16:48:52 PDT 
Comment on attachment 211263 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211263&action=review

r=me

> Source/JavaScriptCore/dfg/DFGNodeFlags.h:101
>      if (flags & NodeMayOverflow)

Call helper.

> Source/JavaScriptCore/dfg/DFGNodeFlags.h:112
> +    if (flags & NodeMayNegZero)

Call helper.
Comment 3 kov's GTK+ EWS bot 2013-09-10 21:30:55 PDT 
Comment on attachment 211263 [details]
the patch

Attachment 211263 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1742522
Comment 4 Filip Pizlo 2013-09-10 21:32:48 PDT 
(In reply to comment #3)
> (From update of attachment 211263 [details])
> Attachment 211263 [details] did not pass gtk-ews (gtk):
> Output: http://webkit-queues.appspot.com/results/1742522

This fail is because GTK+ is applying this patch on top of http://trac.webkit.org/changeset/155497 without rebasing.  The patch I'm about to land has been correctly rebased so it should work.
Comment 5 Filip Pizlo 2013-09-10 21:34:39 PDT 
Landed in http://trac.webkit.org/changeset/155499