Bug 121112 - Re-enable pixel tests on the build bots
Summary: Re-enable pixel tests on the build bots
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 121035
  Show dependency treegraph
 
Reported: 2013-09-10 12:30 PDT by WebKit Commit Bot
Modified: 2021-02-09 11:11 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2013-09-10 12:30:00 PDT
Re-enable pixel tests on the build bots
Requested by rhogan on #webkit.
Comment 1 Robert Hogan 2013-09-10 12:31:01 PDT
Since Blink forked none of the build bots are running pixel tests.

This means that we are not catching painting regressions where the rendertree text dump is unaffected by the regression.

Given that in the vast majority of cases a rebaseline to the pixel result also entails a rebaseline to the rendertree result and vice versa the additional overhead of enabling pixel tests and keeping them up to date is not the 'current effort x 2'. In most cases the rebaselining needs to be done anyway, the rebaseliner just needs to update the png result while they're at it.