Bug 121095 – [EFL] Add parameter to MiniBrowser to disable web security

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Andrzej Badowski]

-w (--web-security) commandline allows to disable/enable web security (enabled by default).

[Andrzej Badowski]

Created attachment 211198 [details]
proposed patch

[Chris Dumez]

Comment on attachment 211198 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211198&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:294
> +

Please test the default value first

> Tools/ChangeLog:8
> +        -w (--web-security) commandline allows to disable/enable web security (enabled by default).

Please explain why it is needed.

[Andrzej Badowski]

Created attachment 211296 [details]
proposed patch 2

as the first patch + supplement according to comments No.1 and No. 2

[WebKit Commit Bot]

Attachment 211296 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp', u'Source/WebKit2/UIProcess/API/efl/ewk_settings.h', u'Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp', u'Tools/ChangeLog', u'Tools/MiniBrowser/efl/main.c']" exit_code: 1
Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp:297:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andrzej Badowski]

Created attachment 211303 [details]
proposed patch 3

[Andrzej Badowski]

Comment on attachment 211303 [details]
proposed patch 3

style bug fixed

[Andrzej Badowski]

The first reason for this, as I mentioned in the last ChangeLog file,  is to test and debug (using, for example, MiniBrowser) scripts accessing resources from other domains (cross-domain requests) such as access map location on another server.
The second reason. A colleague is currently preparing certain types of future tests that will be implemented in the local file and that  will refer to the links in the website http loaded in an iframe. It will not be possible without deactivation of web security.

[Andrzej Badowski]

Created attachment 232196 [details]
proposed_patch_4

update patch webkit.org 121095 - adapt to subsequent changes in webkit.org that occurred after the last patch

[Build Bot]

Comment on attachment 232196 [details]
proposed_patch_4

Attachment 232196 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5203471846342656

New failing tests:
media/media-fragments/TC0001.html

[Build Bot]

Created attachment 232213 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Andrzej Badowski]

Created attachment 232239 [details]
proposed patch 4

Patch no 4 contains only the files from the efl directories.

[Grzegorz Czajkowski]

Comment on attachment 232239 [details]
proposed patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=232239&action=review

Thanks for picking it up. Patch itself looks good to me.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:481
> +EAPI Eina_Bool ewk_settings_web_security_enabled_set(Ewk_Settings* settings, Eina_Bool enable);

Before landing, please update public APIs (headers only) in compliance with EFL coding style, "*" operator should be placed next to variable.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:491
> +EAPI Eina_Bool ewk_settings_web_security_enabled_get(const Ewk_Settings* settings);

Ditto,

[Gyuyoung Kim]

Comment on attachment 232239 [details]
proposed patch 4

LGTM except for Greg's comments. Please land this after fixing those.

[Andrzej Badowski]

Created attachment 232700 [details]
proposed patch

minor style amendments after a positive review

[WebKit Commit Bot]

Comment on attachment 232700 [details]
proposed patch

Clearing flags on attachment: 232700

Committed r169688: <http://trac.webkit.org/changeset/169688>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.