Bug 121093 - [GTK] The code generator produces a warning if a parameter can be NULL
Summary: [GTK] The code generator produces a warning if a parameter can be NULL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alberto Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-10 06:13 PDT by Alberto Garcia
Modified: 2013-09-10 06:31 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2013-09-10 06:15 PDT, Alberto Garcia 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-09-10 06:13:24 PDT 
Here's the warning:

  GEN      DerivedSources/webkitdom/WebKitDOMDOMWindow.h
Use of uninitialized value $CodeGeneratorGObject::cBody[129] in print at ../../Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm line 1536.

The problem is in the generator of the g_return_if_fail() checks at the beginning of each method.

If a particular parameter can be null the generator returns an undefined value instead of an empty string.
Comment 1 Alberto Garcia 2013-09-10 06:15:13 PDT 
Created attachment 211194 [details]
Patch
Comment 2 Chris Dumez 2013-09-10 06:25:11 PDT 
Comment on attachment 211194 [details]
Patch

r=me
Comment 3 Alberto Garcia 2013-09-10 06:31:45 PDT 
Committed r155435: <http://trac.webkit.org/changeset/155435>