RESOLVED FIXED 121093
[GTK] The code generator produces a warning if a parameter can be NULL 
https://bugs.webkit.org/show_bug.cgi?id=121093
Summary [GTK] The code generator produces a warning if a parameter can be NULL
Alberto Garcia
Reported 2013-09-10 06:13:24 PDT
Here's the warning: GEN DerivedSources/webkitdom/WebKitDOMDOMWindow.h Use of uninitialized value $CodeGeneratorGObject::cBody[129] in print at ../../Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm line 1536. The problem is in the generator of the g_return_if_fail() checks at the beginning of each method. If a particular parameter can be null the generator returns an undefined value instead of an empty string.
Attachments
Patch (1.21 KB, patch)
2013-09-10 06:15 PDT, Alberto Garcia 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-09-10 06:15:13 PDT
Created attachment 211194 [details] Patch
Chris Dumez
Comment 2 2013-09-10 06:25:11 PDT
Comment on attachment 211194 [details] Patch r=me
Alberto Garcia
Comment 3 2013-09-10 06:31:45 PDT
Committed r155435: <http://trac.webkit.org/changeset/155435>
Note You need to log in before you can comment on or make changes to this bug.