Bug 121091 - [ATK] Incorrect type for holding float value
Summary: [ATK] Incorrect type for holding float value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-10 05:49 PDT by Krzysztof Czech
Modified: 2013-09-10 07:45 PDT (History)
8 users (show)

See Also:


Attachments
Patch (11.51 KB, patch)
2013-09-10 05:59 PDT, Krzysztof Czech
mario: review+
Details | Formatted Diff | Diff
Patch (11.52 KB, patch)
2013-09-10 07:03 PDT, Krzysztof Czech
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2013-09-10 05:49:37 PDT
Fixing: GLib-GObject-CRITICAL **: g_value_set_float: assertion `G_VALUE_HOLDS_FLOAT (value)' failed.

Basically g_value_set_float doesn't properly set newValue, because it's a double.
Comment 1 Krzysztof Czech 2013-09-10 05:59:50 PDT
Created attachment 211192 [details]
Patch
Comment 2 Mario Sanchez Prada 2013-09-10 06:54:15 PDT
Comment on attachment 211192 [details]
Patch

This patch is a no brainer, but there's a typo in the bug's title which my OCD can't just ignore :).

Giving r+ now, but please fix the ChangeLog before landing.
Comment 3 Mario Sanchez Prada 2013-09-10 06:54:37 PDT
Fixed typo in bug's title
Comment 4 Krzysztof Czech 2013-09-10 07:03:45 PDT
Created attachment 211199 [details]
Patch
Comment 5 Krzysztof Czech 2013-09-10 07:04:11 PDT
> Fixed typo in bug's title
Done
Comment 6 WebKit Commit Bot 2013-09-10 07:45:15 PDT
Comment on attachment 211199 [details]
Patch

Clearing flags on attachment: 211199

Committed r155444: <http://trac.webkit.org/changeset/155444>
Comment 7 WebKit Commit Bot 2013-09-10 07:45:18 PDT
All reviewed patches have been landed.  Closing bug.