Bug 121086 - Apply OVERRIDE and FINAL to Image subclasses and clean them up
Summary: Apply OVERRIDE and FINAL to Image subclasses and clean them up
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on: 121220
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-10 00:54 PDT by Tim Horton
Modified: 2013-09-13 14:16 PDT (History)
8 users (show)

See Also:


Attachments
patch (22.41 KB, patch)
2013-09-10 01:04 PDT, Tim Horton
buildbot: commit-queue-
Details | Formatted Diff | Diff
patch (24.14 KB, patch)
2013-09-10 14:37 PDT, Tim Horton
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-09-10 00:54:39 PDT
Image's subclasses are a bit messy and need some tidying, and are missing our new friends OVERRIDE and FINAL.
Comment 1 Tim Horton 2013-09-10 01:04:40 PDT
Created attachment 211183 [details]
patch

Maybe this should be a few patches, I don't know, I feel silly making lots of patches for this.

Probably it will break other port's builds, but we'll see.
Comment 2 Tim Horton 2013-09-10 01:17:11 PDT
Comment on attachment 211183 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211183&action=review

> Source/WebCore/platform/graphics/BitmapImage.h:-178
> -protected:

It looks like this has been this way effectively forever. I wonder if there's a reason for it?
Comment 3 Build Bot 2013-09-10 01:26:37 PDT
Comment on attachment 211183 [details]
patch

Attachment 211183 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1743156
Comment 4 Build Bot 2013-09-10 01:46:58 PDT
Comment on attachment 211183 [details]
patch

Attachment 211183 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1763036
Comment 5 Tim Horton 2013-09-10 14:37:09 PDT
Created attachment 211245 [details]
patch
Comment 6 Tim Horton 2013-09-12 02:24:43 PDT
Ugh, we really need to fix win-ews. This broke the windows build.