Bug 121085 – GeneratorGeneratedImage should be called GradientImage

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Tim Horton]

Ben removed Generator in http://trac.webkit.org/changeset/150053 but we still have GeneratorGeneratedImage, which now unconditionally takes a gradient. So, this class needs a rename.

[Tim Horton]

Created attachment 212127 [details]
patch

[WebKit Commit Bot]

Attachment 212127 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/CSSGradientValue.cpp', u'Source/WebCore/css/CSSImageGeneratorValue.cpp', u'Source/WebCore/css/CSSImageGeneratorValue.h', u'Source/WebCore/platform/graphics/BitmapImage.h', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp', u'Source/WebCore/platform/graphics/GeneratorGeneratedImage.h', u'Source/WebCore/platform/graphics/GradientImage.cpp', u'Source/WebCore/platform/graphics/GradientImage.h', u'Source/WebCore/platform/graphics/Image.h', u'Source/WebCore/platform/graphics/ImageBuffer.h']" exit_code: 1
Source/WebCore/css/CSSGradientValue.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Created attachment 212128 [details]
style

[WebKit Commit Bot]

Comment on attachment 212128 [details]
style

Clearing flags on attachment: 212128

Committed r156226: <http://trac.webkit.org/changeset/156226>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 212128 [details]
style

View in context: https://bugs.webkit.org/attachment.cgi?id=212128&action=review

> Source/WebCore/platform/graphics/GradientImage.h:45
> +    virtual ~GradientImage() { }

I suggest deleting this line of code.

What this does is exactly what the compiler will automatically do for us if we don’t mention the destructor at all. It’s already virtual because a base class has a virtual destructor. The automatically generated one does the same thing as one with an empty body. Sometimes people will declare the destructor explicitly so we don’t have to include the things necessary to compile it in the header file, but in this case we have an inline definition of it, so that benefit does not apply.

Better style to leave it out.

> Source/WebCore/platform/graphics/GradientImage.h:47
> +protected:

If a class is FINAL, then it makes no sense to have a protected section. These things should just be part of the private section.