Bug 121077 – Remove wtf/Alignment.h

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Remove wtf/Alignment.h

[Anders Carlsson]

Created attachment 211165 [details]
Patch

[Early Warning System Bot]

Comment on attachment 211165 [details]
Patch

Attachment 211165 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1743130

[Early Warning System Bot]

Comment on attachment 211165 [details]
Patch

Attachment 211165 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1750005

[Darin Adler]

Comment on attachment 211165 [details]
Patch

/home/webkit/WebKit/Source/WTF/wtf/Vector.h:1042:9: error: array subscript is above array bounds [-Werror=array-bounds]

[Build Bot]

Comment on attachment 211165 [details]
Patch

Attachment 211165 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1752001

[Anders Carlsson]

Created attachment 211173 [details]
Patch

[Early Warning System Bot]

Comment on attachment 211173 [details]
Patch

Attachment 211173 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1762002

[Early Warning System Bot]

Comment on attachment 211173 [details]
Patch

Attachment 211173 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1763004

[Anders Carlsson]

Created attachment 211176 [details]
Patch

[Early Warning System Bot]

Comment on attachment 211176 [details]
Patch

Attachment 211176 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1734538

[Early Warning System Bot]

Comment on attachment 211176 [details]
Patch

Attachment 211176 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1761013

[Anders Carlsson]

Created attachment 211182 [details]
Patch

[Early Warning System Bot]

Comment on attachment 211182 [details]
Patch

Attachment 211182 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1666020

[Early Warning System Bot]

Comment on attachment 211182 [details]
Patch

Attachment 211182 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1751014

[Build Bot]

Comment on attachment 211182 [details]
Patch

Attachment 211182 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1738374

New failing tests:
compositing/backface-visibility/backface-visibility-hierarchical-transform.html
compositing/absolute-inside-out-of-view-fixed.html
animations/3d/matrix-transform-type-animation.html
animations/3d/state-at-end-event-transform.html
animations/added-while-suspended.html
animations/animation-add-events-in-handler.html
animations/additive-transform-animations.html
animations/3d/replace-filling-transform.html
accessibility/accessibility-object-detached.html
compositing/backface-visibility/backface-visibility-3d.html
accessibility/accessibility-node-reparent.html
animations/animation-border-overflow.html
http/tests/appcache/abort-cache-onchecking-resource-404.html
compositing/animation/animation-compositing.html
animations/animation-controller-drt-api.html
animations/3d/change-transform-in-end-event.html
compositing/absolute-position-changed-in-composited-layer.html
canvas/philip/tests/2d.canvas.readonly.html
compositing/animation/animated-composited-inside-hidden.html
http/tests/appcache/abort-cache-onchecking-manifest-404.html
canvas/philip/tests/2d.canvas.reference.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
http/tests/appcache/404-resource.html
animations/3d/transform-origin-vs-functions.html
accessibility/accessibility-node-memory-management.html
http/tests/appcache/abort-cache-onchecking.html
accessibility/adjacent-continuations-cause-assertion-failure.html
http/tests/appcache/404-manifest.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html

[Build Bot]

Created attachment 211196 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Anders Carlsson]

Comment on attachment 211182 [details]
Patch

Doing this in smaller steps instead.

[Anders Carlsson]

Created attachment 211256 [details]
Patch

[Anders Carlsson]

Created attachment 211258 [details]
Patch

[Andreas Kling]

Comment on attachment 211258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211258&action=review

> Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:97
> +        FELightingFloatArgumentsForNeon, floatArguments;

, :(

[Anders Carlsson]

Committed r155491: <http://trac.webkit.org/changeset/155491>

[Csaba Osztrogonác]

(In reply to comment #21)
> Committed r155491: <http://trac.webkit.org/changeset/155491>

It broke the ARM build, because WTF_ALIGNED is still used in
Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp.
new bug report for it: https://bugs.webkit.org/show_bug.cgi?id=121152

Additionally it seems WTF_ALIGNED is still used in 
Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp too,
cc-ing BlackBerry guys.