Bug 121077 - Remove wtf/Alignment.h
Summary: Remove wtf/Alignment.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 121152
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-09 23:07 PDT by Anders Carlsson
Modified: 2013-09-11 04:15 PDT (History)
14 users (show)

See Also:

Attachments
Patch (18.18 KB, patch)
2013-09-09 23:09 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (19.94 KB, patch)
2013-09-09 23:39 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (20.48 KB, patch)
2013-09-09 23:56 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (20.50 KB, patch)
2013-09-10 00:40 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (279.30 KB, application/zip)
2013-09-10 06:38 PDT, Build Bot 		no flags Details
Patch (12.70 KB, patch)
2013-09-10 15:47 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (12.97 KB, patch)
2013-09-10 15:54 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-09-09 23:07:45 PDT 
Remove wtf/Alignment.h
Comment 1 Anders Carlsson 2013-09-09 23:09:04 PDT 
Created attachment 211165 [details]
Patch
Comment 2 Early Warning System Bot 2013-09-09 23:21:13 PDT 
Comment on attachment 211165 [details]
Patch

Attachment 211165 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1743130
Comment 3 Early Warning System Bot 2013-09-09 23:24:08 PDT 
Comment on attachment 211165 [details]
Patch

Attachment 211165 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1750005
Comment 4 Darin Adler 2013-09-09 23:32:28 PDT 
Comment on attachment 211165 [details]
Patch

/home/webkit/WebKit/Source/WTF/wtf/Vector.h:1042:9: error: array subscript is above array bounds [-Werror=array-bounds]
Comment 5 Build Bot 2013-09-09 23:32:53 PDT 
Comment on attachment 211165 [details]
Patch

Attachment 211165 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1752001
Comment 6 Anders Carlsson 2013-09-09 23:39:26 PDT 
Created attachment 211173 [details]
Patch
Comment 7 Early Warning System Bot 2013-09-09 23:51:15 PDT 
Comment on attachment 211173 [details]
Patch

Attachment 211173 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1762002
Comment 8 Early Warning System Bot 2013-09-09 23:54:41 PDT 
Comment on attachment 211173 [details]
Patch

Attachment 211173 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1763004
Comment 9 Anders Carlsson 2013-09-09 23:56:30 PDT 
Created attachment 211176 [details]
Patch
Comment 10 Early Warning System Bot 2013-09-10 00:17:26 PDT 
Comment on attachment 211176 [details]
Patch

Attachment 211176 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1734538
Comment 11 Early Warning System Bot 2013-09-10 00:17:34 PDT 
Comment on attachment 211176 [details]
Patch

Attachment 211176 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1761013
Comment 12 Anders Carlsson 2013-09-10 00:40:34 PDT 
Created attachment 211182 [details]
Patch
Comment 13 Early Warning System Bot 2013-09-10 00:52:38 PDT 
Comment on attachment 211182 [details]
Patch

Attachment 211182 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1666020
Comment 14 Early Warning System Bot 2013-09-10 00:55:11 PDT 
Comment on attachment 211182 [details]
Patch

Attachment 211182 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1751014
Comment 15 Build Bot 2013-09-10 06:38:51 PDT 
Comment on attachment 211182 [details]
Patch

Attachment 211182 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1738374

New failing tests:
compositing/backface-visibility/backface-visibility-hierarchical-transform.html
compositing/absolute-inside-out-of-view-fixed.html
animations/3d/matrix-transform-type-animation.html
animations/3d/state-at-end-event-transform.html
animations/added-while-suspended.html
animations/animation-add-events-in-handler.html
animations/additive-transform-animations.html
animations/3d/replace-filling-transform.html
accessibility/accessibility-object-detached.html
compositing/backface-visibility/backface-visibility-3d.html
accessibility/accessibility-node-reparent.html
animations/animation-border-overflow.html
http/tests/appcache/abort-cache-onchecking-resource-404.html
compositing/animation/animation-compositing.html
animations/animation-controller-drt-api.html
animations/3d/change-transform-in-end-event.html
compositing/absolute-position-changed-in-composited-layer.html
canvas/philip/tests/2d.canvas.readonly.html
compositing/animation/animated-composited-inside-hidden.html
http/tests/appcache/abort-cache-onchecking-manifest-404.html
canvas/philip/tests/2d.canvas.reference.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
http/tests/appcache/404-resource.html
animations/3d/transform-origin-vs-functions.html
accessibility/accessibility-node-memory-management.html
http/tests/appcache/abort-cache-onchecking.html
accessibility/adjacent-continuations-cause-assertion-failure.html
http/tests/appcache/404-manifest.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html
Comment 16 Build Bot 2013-09-10 06:38:53 PDT 
Created attachment 211196 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 17 Anders Carlsson 2013-09-10 14:08:59 PDT 
Comment on attachment 211182 [details]
Patch

Doing this in smaller steps instead.
Comment 18 Anders Carlsson 2013-09-10 15:47:43 PDT 
Created attachment 211256 [details]
Patch
Comment 19 Anders Carlsson 2013-09-10 15:54:28 PDT 
Created attachment 211258 [details]
Patch
Comment 20 Andreas Kling 2013-09-10 16:32:28 PDT 
Comment on attachment 211258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211258&action=review

> Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h:97
> +        FELightingFloatArgumentsForNeon, floatArguments;

, :(
Comment 21 Anders Carlsson 2013-09-10 16:36:37 PDT 
Committed r155491: <http://trac.webkit.org/changeset/155491>
Comment 22 Csaba Osztrogonác 2013-09-11 04:15:10 PDT 
(In reply to comment #21)
> Committed r155491: <http://trac.webkit.org/changeset/155491>

It broke the ARM build, because WTF_ALIGNED is still used in
Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp.
new bug report for it: https://bugs.webkit.org/show_bug.cgi?id=121152

Additionally it seems WTF_ALIGNED is still used in 
Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp too,
cc-ing BlackBerry guys.