Bug 121075 - Move layering-violating code from Pasteboard::plainText into Editor (Mac only at first)
Summary: Move layering-violating code from Pasteboard::plainText into Editor (Mac only...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-09 21:28 PDT by Darin Adler
Modified: 2013-09-12 09:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (16.18 KB, patch)
2013-09-09 21:33 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (635.74 KB, application/zip)
2013-09-09 22:20 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (552.75 KB, application/zip)
2013-09-09 22:22 PDT, Build Bot 		no flags Details
Patch (16.31 KB, patch)
2013-09-12 07:43 PDT, Darin Adler 		andersca: review+
andersca: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-09-09 21:28:30 PDT 
Move layering-violating code from Pasteboard::plainText into Editor (Mac only at first)
Comment 1 Darin Adler 2013-09-09 21:33:41 PDT 
Created attachment 211154 [details]
Patch
Comment 2 Build Bot 2013-09-09 22:19:58 PDT 
Comment on attachment 211154 [details]
Patch

Attachment 211154 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1726806

New failing tests:
editing/pasteboard/4076267-3.html
editing/pasteboard/copy-null-characters.html
editing/pasteboard/copy-paste-ruby-text.html
editing/pasteboard/copy-backslash-with-euc.html
editing/pasteboard/copy-image-with-alt-text.html
editing/pasteboard/copy-paste-ruby-text-with-block.html
editing/pasteboard/4076267.html
Comment 3 Build Bot 2013-09-09 22:20:00 PDT 
Created attachment 211161 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 4 Build Bot 2013-09-09 22:22:07 PDT 
Comment on attachment 211154 [details]
Patch

Attachment 211154 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1726807

New failing tests:
editing/pasteboard/4076267-3.html
editing/pasteboard/copy-null-characters.html
editing/pasteboard/copy-paste-ruby-text.html
editing/pasteboard/copy-backslash-with-euc.html
editing/pasteboard/copy-image-with-alt-text.html
editing/pasteboard/copy-paste-ruby-text-with-block.html
editing/pasteboard/4076267.html
Comment 5 Build Bot 2013-09-09 22:22:08 PDT 
Created attachment 211162 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 6 Darin Adler 2013-09-12 07:43:48 PDT 
Created attachment 211427 [details]
Patch
Comment 7 Darin Adler 2013-09-12 07:44:08 PDT 
First patch had one missing return statement, causing regression test failures.
Comment 8 Anders Carlsson 2013-09-12 08:29:54 PDT 
Comment on attachment 211427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211427&action=review

> Source/WebCore/platform/mac/PasteboardMac.mm:297
> +            if (RetainPtr<NSAttributedString> attributedString = [[NSAttributedString alloc] initWithRTF:[data->createNSData() autorelease] documentAttributes:NULL]) {

Missing an adoptNS here! Also, i'd use auto instead of repeating the type twice here.
Comment 9 Darin Adler 2013-09-12 09:22:00 PDT 
Comment on attachment 211427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211427&action=review

>> Source/WebCore/platform/mac/PasteboardMac.mm:297
>> +            if (RetainPtr<NSAttributedString> attributedString = [[NSAttributedString alloc] initWithRTF:[data->createNSData() autorelease] documentAttributes:NULL]) {
> 
> Missing an adoptNS here! Also, i'd use auto instead of repeating the type twice here.

I didn’t use auto because auto will give me PassRefPtr, not RefPtr.
Comment 10 Darin Adler 2013-09-12 09:46:43 PDT 
Committed r155625: <http://trac.webkit.org/changeset/155625>