Bug 121075 – Move layering-violating code from Pasteboard::plainText into Editor (Mac only at first)

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Darin Adler]

Move layering-violating code from Pasteboard::plainText into Editor (Mac only at first)

[Darin Adler]

Created attachment 211154 [details]
Patch

[Build Bot]

Comment on attachment 211154 [details]
Patch

Attachment 211154 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1726806

New failing tests:
editing/pasteboard/4076267-3.html
editing/pasteboard/copy-null-characters.html
editing/pasteboard/copy-paste-ruby-text.html
editing/pasteboard/copy-backslash-with-euc.html
editing/pasteboard/copy-image-with-alt-text.html
editing/pasteboard/copy-paste-ruby-text-with-block.html
editing/pasteboard/4076267.html

[Build Bot]

Created attachment 211161 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 211154 [details]
Patch

Attachment 211154 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1726807

New failing tests:
editing/pasteboard/4076267-3.html
editing/pasteboard/copy-null-characters.html
editing/pasteboard/copy-paste-ruby-text.html
editing/pasteboard/copy-backslash-with-euc.html
editing/pasteboard/copy-image-with-alt-text.html
editing/pasteboard/copy-paste-ruby-text-with-block.html
editing/pasteboard/4076267.html

[Build Bot]

Created attachment 211162 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Darin Adler]

Created attachment 211427 [details]
Patch

[Darin Adler]

First patch had one missing return statement, causing regression test failures.

[Anders Carlsson]

Comment on attachment 211427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211427&action=review

> Source/WebCore/platform/mac/PasteboardMac.mm:297
> +            if (RetainPtr<NSAttributedString> attributedString = [[NSAttributedString alloc] initWithRTF:[data->createNSData() autorelease] documentAttributes:NULL]) {

Missing an adoptNS here! Also, i'd use auto instead of repeating the type twice here.

[Darin Adler]

Comment on attachment 211427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211427&action=review

>> Source/WebCore/platform/mac/PasteboardMac.mm:297
>> +            if (RetainPtr<NSAttributedString> attributedString = [[NSAttributedString alloc] initWithRTF:[data->createNSData() autorelease] documentAttributes:NULL]) {
> 
> Missing an adoptNS here! Also, i'd use auto instead of repeating the type twice here.

I didn’t use auto because auto will give me PassRefPtr, not RefPtr.

[Darin Adler]

Committed r155625: <http://trac.webkit.org/changeset/155625>