Bug 121057 - There should be one "invalid" virtual register constant
Summary: There should be one "invalid" virtual register constant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 118758
  Show dependency tree / graph
 
Reported: 2013-09-09 16:04 PDT by Michael Saboff
Modified: 2013-09-09 23:08 PDT (History)
0 users

See Also:

Attachments
Patch (6.89 KB, patch)
2013-09-09 16:21 PDT, Michael Saboff 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-09-09 16:04:36 PDT 
This is in preparation for inverting the JSC stack.  Currently a virtual register value of -1 is used as an invalid virtual register.  When the stack is inverted, -1 will be a valid register.  Some places in the code use a literal -1 while others use the enum InvalidVirtualRegister.  All places should use the InvalidVirtualRegister enum and its value should be a reasonable "invalid" value.
Comment 1 Michael Saboff 2013-09-09 16:21:05 PDT 
Created attachment 211113 [details]
Patch
Comment 2 Michael Saboff 2013-09-09 23:08:44 PDT 
Committed r155420: <http://trac.webkit.org/changeset/155420>