Bug 121055 - Change virtual register function arguments and locals from unsigned to int
Summary: Change virtual register function arguments and locals from unsigned to int
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks: 118758
  Show dependency tree / graph
 
Reported: 2013-09-09 15:37 PDT by Michael Saboff
Modified: 2013-09-09 23:00 PDT (History)
0 users

See Also:

Attachments
Patch (108.91 KB, patch)
2013-09-09 15:43 PDT, Michael Saboff 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-09-09 15:37:33 PDT 
This is part of making the change for https://bugs.webkit.org/show_bug.cgi?id=118758 - "fourthTier: Change JSStack to grow from high to low addresses".  In many places the the type of virtual register variables and argument are unsigned.  These should be changed since offsets can be both positive and negative.
Comment 1 Michael Saboff 2013-09-09 15:43:56 PDT 
Created attachment 211108 [details]
Patch

Builds and passes JS tests for both 32 and 64 bit.
Comment 2 Geoffrey Garen 2013-09-09 17:14:37 PDT 
Comment on attachment 211108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211108&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        This is a largely mechanical change.  This changes function paramaters and local variables use to

Should be "used".

> Source/JavaScriptCore/ChangeLog:19
> +        * bytecode/CodeOrigin.h:
> +        * dfg/DFGByteCodeParser.cpp:
> +        (JSC::DFG::ByteCodeParser::getDirect):
> +        (JSC::DFG::ByteCodeParser::setDirect):
> +        (JSC::DFG::ByteCodeParser::getLocal):
> +        (JSC::DFG::ByteCodeParser::setLocal):
> +        (JSC::DFG::ByteCodeParser::parseBlock):
> +        * jit/JIT.h:
> +        (JSC::JIT::emitStoreCell):

I don't think this empty function list is super helpful. Perhaps you could truncate it to a file list.
Comment 3 Michael Saboff 2013-09-09 23:00:07 PDT 
Committed r155418: <http://trac.webkit.org/changeset/155418>