Bug 121055 – Change virtual register function arguments and locals from unsigned to int

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

This is part of making the change for https://bugs.webkit.org/show_bug.cgi?id=118758 - "fourthTier: Change JSStack to grow from high to low addresses".  In many places the the type of virtual register variables and argument are unsigned.  These should be changed since offsets can be both positive and negative.

[Michael Saboff]

Created attachment 211108 [details]
Patch

Builds and passes JS tests for both 32 and 64 bit.

[Geoffrey Garen]

Comment on attachment 211108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211108&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        This is a largely mechanical change.  This changes function paramaters and local variables use to

Should be "used".

> Source/JavaScriptCore/ChangeLog:19
> +        * bytecode/CodeOrigin.h:
> +        * dfg/DFGByteCodeParser.cpp:
> +        (JSC::DFG::ByteCodeParser::getDirect):
> +        (JSC::DFG::ByteCodeParser::setDirect):
> +        (JSC::DFG::ByteCodeParser::getLocal):
> +        (JSC::DFG::ByteCodeParser::setLocal):
> +        (JSC::DFG::ByteCodeParser::parseBlock):
> +        * jit/JIT.h:
> +        (JSC::JIT::emitStoreCell):

I don't think this empty function list is super helpful. Perhaps you could truncate it to a file list.

[Michael Saboff]

Committed r155418: <http://trac.webkit.org/changeset/155418>