Bug 121047 - Remove wtf/TypeTraits.h
Summary: Remove wtf/TypeTraits.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-09 14:05 PDT by Anders Carlsson
Modified: 2013-09-09 16:36 PDT (History)
11 users (show)

See Also:

Attachments
Patch (30.43 KB, patch)
2013-09-09 14:06 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (31.34 KB, patch)
2013-09-09 14:51 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (31.28 KB, patch)
2013-09-09 14:53 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (31.98 KB, patch)
2013-09-09 14:58 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (32.61 KB, patch)
2013-09-09 15:01 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (33.67 KB, patch)
2013-09-09 15:08 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (36.29 KB, patch)
2013-09-09 15:40 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-09-09 14:05:46 PDT 
Remove wtf/TypeTraits.h
Comment 1 Anders Carlsson 2013-09-09 14:06:59 PDT 
Created attachment 211083 [details]
Patch
Comment 2 Andreas Kling 2013-09-09 14:08:17 PDT 
Comment on attachment 211083 [details]
Patch

Cool.
Comment 3 Early Warning System Bot 2013-09-09 14:20:10 PDT 
Comment on attachment 211083 [details]
Patch

Attachment 211083 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1737263
Comment 4 Early Warning System Bot 2013-09-09 14:22:08 PDT 
Comment on attachment 211083 [details]
Patch

Attachment 211083 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1719982
Comment 5 Build Bot 2013-09-09 14:36:05 PDT 
Comment on attachment 211083 [details]
Patch

Attachment 211083 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1725641
Comment 6 Build Bot 2013-09-09 14:49:58 PDT 
Comment on attachment 211083 [details]
Patch

Attachment 211083 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1734410
Comment 7 Anders Carlsson 2013-09-09 14:51:24 PDT 
Created attachment 211090 [details]
Patch
Comment 8 Anders Carlsson 2013-09-09 14:53:48 PDT 
Created attachment 211092 [details]
Patch
Comment 9 Anders Carlsson 2013-09-09 14:58:41 PDT 
Created attachment 211095 [details]
Patch
Comment 10 Anders Carlsson 2013-09-09 15:01:29 PDT 
Created attachment 211096 [details]
Patch
Comment 11 Anders Carlsson 2013-09-09 15:08:42 PDT 
Created attachment 211099 [details]
Patch
Comment 12 Darin Adler 2013-09-09 15:14:45 PDT 
Comment on attachment 211099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211099&action=review

> Source/JavaScriptCore/jsc.cpp:-264
> -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false);

Why was this here? Why is it going?

> Source/JavaScriptCore/testRegExp.cpp:-142
> -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false);

Why was this here? Why is it going?
Comment 13 Early Warning System Bot 2013-09-09 15:35:08 PDT 
Comment on attachment 211099 [details]
Patch

Attachment 211099 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1728509
Comment 14 Early Warning System Bot 2013-09-09 15:35:35 PDT 
Comment on attachment 211099 [details]
Patch

Attachment 211099 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1742161
Comment 15 Build Bot 2013-09-09 15:36:29 PDT 
Comment on attachment 211099 [details]
Patch

Attachment 211099 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1736419
Comment 16 kov's GTK+ EWS bot 2013-09-09 15:36:41 PDT 
Comment on attachment 211099 [details]
Patch

Attachment 211099 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1743011
Comment 17 Anders Carlsson 2013-09-09 15:36:52 PDT 
(In reply to comment #12)
> (From update of attachment 211099 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211099&action=review
> 
> > Source/JavaScriptCore/jsc.cpp:-264
> > -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false);
> 
> Why was this here? Why is it going?

I have no idea why it was there. GlobalObject is a class so asserting that it’s not an integer seems pointless.

> 
> > Source/JavaScriptCore/testRegExp.cpp:-142
> > -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false);
> 
> Why was this here? Why is it going?

I think it’s either been copied from jsc.cpp, or the other way around.
Comment 18 Anders Carlsson 2013-09-09 15:40:58 PDT 
Created attachment 211106 [details]
Patch
Comment 19 WebKit Commit Bot 2013-09-09 16:36:42 PDT 
Comment on attachment 211106 [details]
Patch

Clearing flags on attachment: 211106

Committed r155402: <http://trac.webkit.org/changeset/155402>
Comment 20 WebKit Commit Bot 2013-09-09 16:36:46 PDT 
All reviewed patches have been landed.  Closing bug.