Bug 121047 – Remove wtf/TypeTraits.h

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Remove wtf/TypeTraits.h

[Anders Carlsson]

Created attachment 211083 [details]
Patch

[Andreas Kling]

Comment on attachment 211083 [details]
Patch

Cool.

[Early Warning System Bot]

Comment on attachment 211083 [details]
Patch

Attachment 211083 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1737263

[Early Warning System Bot]

Comment on attachment 211083 [details]
Patch

Attachment 211083 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1719982

[Build Bot]

Comment on attachment 211083 [details]
Patch

Attachment 211083 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1725641

[Build Bot]

Comment on attachment 211083 [details]
Patch

Attachment 211083 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1734410

[Anders Carlsson]

Created attachment 211090 [details]
Patch

[Anders Carlsson]

Created attachment 211092 [details]
Patch

[Anders Carlsson]

Created attachment 211095 [details]
Patch

[Anders Carlsson]

Created attachment 211096 [details]
Patch

[Anders Carlsson]

Created attachment 211099 [details]
Patch

[Darin Adler]

Comment on attachment 211099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211099&action=review

> Source/JavaScriptCore/jsc.cpp:-264
> -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false);

Why was this here? Why is it going?

> Source/JavaScriptCore/testRegExp.cpp:-142
> -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false);

Why was this here? Why is it going?

[Early Warning System Bot]

Comment on attachment 211099 [details]
Patch

Attachment 211099 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1728509

[Early Warning System Bot]

Comment on attachment 211099 [details]
Patch

Attachment 211099 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1742161

[Build Bot]

Comment on attachment 211099 [details]
Patch

Attachment 211099 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1736419

[kov's GTK+ EWS bot]

Comment on attachment 211099 [details]
Patch

Attachment 211099 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1743011

[Anders Carlsson]

(In reply to comment #12)
> (From update of attachment 211099 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211099&action=review
> 
> > Source/JavaScriptCore/jsc.cpp:-264
> > -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false);
> 
> Why was this here? Why is it going?

I have no idea why it was there. GlobalObject is a class so asserting that it’s not an integer seems pointless.

> 
> > Source/JavaScriptCore/testRegExp.cpp:-142
> > -COMPILE_ASSERT(!IsInteger<GlobalObject>::value, WTF_IsInteger_GlobalObject_false);
> 
> Why was this here? Why is it going?

I think it’s either been copied from jsc.cpp, or the other way around.

[Anders Carlsson]

Created attachment 211106 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 211106 [details]
Patch

Clearing flags on attachment: 211106

Committed r155402: <http://trac.webkit.org/changeset/155402>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.