RESOLVED FIXED Bug 121034
MediaStreamDescriptor::removeAudioComponent accidentally changes m_videoComponents 
https://bugs.webkit.org/show_bug.cgi?id=121034
Summary MediaStreamDescriptor::removeAudioComponent accidentally changes m_videoCompo...
Thiago de Barros Lacerda
Reported 2013-09-09 10:53:59 PDT
removeAudioComponent is calling remove in video components vector by mistake
Attachments
Patch (1.68 KB, patch)
2013-09-09 10:55 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2013-09-09 10:55:30 PDT
Created attachment 211057 [details] Patch
Alexey Proskuryakov
Comment 2 2013-09-09 12:39:04 PDT
Re-titled - we use bracketed prefixes for special interest bugs that most people just want to quickly skip over (like platform specific issues).
WebKit Commit Bot
Comment 3 2013-09-09 14:31:50 PDT
Comment on attachment 211057 [details] Patch Clearing flags on attachment: 211057 Committed r155382: <http://trac.webkit.org/changeset/155382>
WebKit Commit Bot
Comment 4 2013-09-09 14:31:52 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2013-09-09 14:41:48 PDT
Comment on attachment 211057 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211057&action=review > Source/WebCore/ChangeLog:8 > + No new tests needed. Why? Looks like this was a bad bug. Normally we’d want a regression test.
Thiago de Barros Lacerda
Comment 6 2013-09-09 14:46:47 PDT
(In reply to comment #5) > (From update of attachment 211057 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=211057&action=review > > > Source/WebCore/ChangeLog:8 > > + No new tests needed. > > Why? Looks like this was a bad bug. Normally we’d want a regression test. Darin, this was just introduced by accident in this revision https://bugs.webkit.org/show_bug.cgi?id=120872. So I think does not need an Test for that
Note You need to log in before you can comment on or make changes to this bug.