Bug 121030 - [webkitpy] Remove the DeprecatedPort class
Summary: [webkitpy] Remove the DeprecatedPort class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-09 09:01 PDT by Zan Dobersek
Modified: 2013-10-19 11:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (67.04 KB, patch)
2013-09-09 09:47 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-09-09 09:01:45 PDT 
[webkitpy] Remove the DeprecatedPort class
Comment 1 Zan Dobersek 2013-09-09 09:47:11 PDT 
Created attachment 211051 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-09 09:49:16 PDT 
Attachment 211051 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/common/config/ports.py', u'Tools/Scripts/webkitpy/common/config/ports_mock.py', u'Tools/Scripts/webkitpy/common/config/ports_unittest.py', u'Tools/Scripts/webkitpy/port/base.py', u'Tools/Scripts/webkitpy/port/base_unittest.py', u'Tools/Scripts/webkitpy/port/efl.py', u'Tools/Scripts/webkitpy/port/efl_unittest.py', u'Tools/Scripts/webkitpy/port/gtk.py', u'Tools/Scripts/webkitpy/port/gtk_unittest.py', u'Tools/Scripts/webkitpy/port/mac_unittest.py', u'Tools/Scripts/webkitpy/port/qt.py', u'Tools/Scripts/webkitpy/port/qt_unittest.py', u'Tools/Scripts/webkitpy/port/test.py', u'Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py', u'Tools/Scripts/webkitpy/tool/bot/irc_command.py', u'Tools/Scripts/webkitpy/tool/commands/download_unittest.py', u'Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py', u'Tools/Scripts/webkitpy/tool/commands/queues.py', u'Tools/Scripts/webkitpy/tool/main.py', u'Tools/Scripts/webkitpy/tool/mocktool.py', u'Tools/Scripts/webkitpy/tool/steps/build.py', u'Tools/Scripts/webkitpy/tool/steps/checkstyle.py', u'Tools/Scripts/webkitpy/tool/steps/commit.py', u'Tools/Scripts/webkitpy/tool/steps/preparechangelog.py', u'Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py', u'Tools/Scripts/webkitpy/tool/steps/runtests.py', u'Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py', u'Tools/Scripts/webkitpy/tool/steps/steps_unittest.py', u'Tools/Scripts/webkitpy/tool/steps/update.py', u'Tools/Scripts/webkitpy/tool/steps/update_unittest.py']" exit_code: 1
Tools/Scripts/webkitpy/port/test.py:555:  [TestPort.run_python_unittests_command] An attribute affected in webkitpy.tool.steps.runtests_unittest line 40 hide this method  [pylint/E0202] [5]
Tools/Scripts/webkitpy/port/test.py:558:  [TestPort.run_perl_unittests_command] An attribute affected in webkitpy.tool.steps.runtests_unittest line 41 hide this method  [pylint/E0202] [5]
Total errors found: 2 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2013-09-09 12:41:53 PDT 
Comment on attachment 211051 [details]
Patch

Clearing flags on attachment: 211051

Committed r155373: <http://trac.webkit.org/changeset/155373>
Comment 4 Zan Dobersek 2013-09-09 12:41:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryosuke Niwa 2013-10-19 11:54:18 PDT 
This regressed EWS. Now all EWS bots are using the default port in the environment.