RESOLVED FIXED 121030
[webkitpy] Remove the DeprecatedPort class 
https://bugs.webkit.org/show_bug.cgi?id=121030
Summary [webkitpy] Remove the DeprecatedPort class
Zan Dobersek
Reported 2013-09-09 09:01:45 PDT
[webkitpy] Remove the DeprecatedPort class
Attachments
Patch (67.04 KB, patch)
2013-09-09 09:47 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-09-09 09:47:11 PDT
Created attachment 211051 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-09 09:49:16 PDT
Attachment 211051 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy/common/config/ports.py', u'Tools/Scripts/webkitpy/common/config/ports_mock.py', u'Tools/Scripts/webkitpy/common/config/ports_unittest.py', u'Tools/Scripts/webkitpy/port/base.py', u'Tools/Scripts/webkitpy/port/base_unittest.py', u'Tools/Scripts/webkitpy/port/efl.py', u'Tools/Scripts/webkitpy/port/efl_unittest.py', u'Tools/Scripts/webkitpy/port/gtk.py', u'Tools/Scripts/webkitpy/port/gtk_unittest.py', u'Tools/Scripts/webkitpy/port/mac_unittest.py', u'Tools/Scripts/webkitpy/port/qt.py', u'Tools/Scripts/webkitpy/port/qt_unittest.py', u'Tools/Scripts/webkitpy/port/test.py', u'Tools/Scripts/webkitpy/tool/bot/flakytestreporter.py', u'Tools/Scripts/webkitpy/tool/bot/irc_command.py', u'Tools/Scripts/webkitpy/tool/commands/download_unittest.py', u'Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py', u'Tools/Scripts/webkitpy/tool/commands/queues.py', u'Tools/Scripts/webkitpy/tool/main.py', u'Tools/Scripts/webkitpy/tool/mocktool.py', u'Tools/Scripts/webkitpy/tool/steps/build.py', u'Tools/Scripts/webkitpy/tool/steps/checkstyle.py', u'Tools/Scripts/webkitpy/tool/steps/commit.py', u'Tools/Scripts/webkitpy/tool/steps/preparechangelog.py', u'Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert.py', u'Tools/Scripts/webkitpy/tool/steps/runtests.py', u'Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py', u'Tools/Scripts/webkitpy/tool/steps/steps_unittest.py', u'Tools/Scripts/webkitpy/tool/steps/update.py', u'Tools/Scripts/webkitpy/tool/steps/update_unittest.py']" exit_code: 1 Tools/Scripts/webkitpy/port/test.py:555: [TestPort.run_python_unittests_command] An attribute affected in webkitpy.tool.steps.runtests_unittest line 40 hide this method [pylint/E0202] [5] Tools/Scripts/webkitpy/port/test.py:558: [TestPort.run_perl_unittests_command] An attribute affected in webkitpy.tool.steps.runtests_unittest line 41 hide this method [pylint/E0202] [5] Total errors found: 2 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan Dobersek
Comment 3 2013-09-09 12:41:53 PDT
Comment on attachment 211051 [details] Patch Clearing flags on attachment: 211051 Committed r155373: <http://trac.webkit.org/changeset/155373>
Zan Dobersek
Comment 4 2013-09-09 12:41:59 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 5 2013-10-19 11:54:18 PDT
This regressed EWS. Now all EWS bots are using the default port in the environment.
Note You need to log in before you can comment on or make changes to this bug.