Bug 121029 - matchingShorthandsForLonghand builds map using a giant function
Summary: matchingShorthandsForLonghand builds map using a giant function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-09 08:38 PDT by Darin Adler
Modified: 2013-09-09 09:26 PDT (History)
7 users (show)

See Also:

Attachments
Patch (73.99 KB, patch)
2013-09-09 08:48 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-09-09 08:38:38 PDT 
matchingShorthandsForLonghand builds map using a giant function
Comment 1 Darin Adler 2013-09-09 08:48:00 PDT 
Created attachment 211045 [details]
Patch
Comment 2 Anders Carlsson 2013-09-09 08:56:36 PDT 
Comment on attachment 211045 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211045&action=review

> Source/WebCore/css/StylePropertyShorthand.cpp:598
> +static Vector<StylePropertyShorthand> makeVector(const StylePropertyShorthand& a)
> +{
> +    return Vector<StylePropertyShorthand>(1, a);
> +}

I wish we could use std::initializer_list so we wouldn't need any of these helpers!
Comment 3 WebKit Commit Bot 2013-09-09 09:26:56 PDT 
Comment on attachment 211045 [details]
Patch

Clearing flags on attachment: 211045

Committed r155352: <http://trac.webkit.org/changeset/155352>
Comment 4 WebKit Commit Bot 2013-09-09 09:26:58 PDT 
All reviewed patches have been landed.  Closing bug.