Bug 121028 - Hide Document::renderer()
Summary: Hide Document::renderer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-09 03:29 PDT by Antti Koivisto
Modified: 2013-09-09 09:49 PDT (History)
0 users

See Also:

Attachments
patch (27.92 KB, patch)
2013-09-09 03:31 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-09 03:29:10 PDT 
Use Document::renderView() instead.
Comment 1 Antti Koivisto 2013-09-09 03:31:46 PDT 
Created attachment 211024 [details]
patch
Comment 2 Andreas Kling 2013-09-09 03:33:30 PDT 
Comment on attachment 211024 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211024&action=review

A+, good patch, would review again!

> Source/WebCore/dom/Document.h:-546
> -    // FIXME: Remove this, callers that have a Document* should call renderView().
> -    // Shadow the implementations on Node to provide faster access for documents.
> -    RenderView* renderer() const { return m_renderView; }

Thanks for fixing my FIXME! :D
Comment 3 Antti Koivisto 2013-09-09 03:36:52 PDT 
https://trac.webkit.org/r155344
Comment 4 Darin Adler 2013-09-09 09:49:20 PDT 
Comment on attachment 211024 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211024&action=review

> Source/WebCore/dom/Document.h:1187
> +    RenderObject* renderer() const WTF_DELETED_FUNCTION;

In cases like this I often just make the return type void.