RESOLVED FIXED Bug 121028
Hide Document::renderer() 
https://bugs.webkit.org/show_bug.cgi?id=121028
Summary Hide Document::renderer()
Antti Koivisto
Reported 2013-09-09 03:29:10 PDT
Use Document::renderView() instead.
Attachments
patch (27.92 KB, patch)
2013-09-09 03:31 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-09-09 03:31:46 PDT
Created attachment 211024 [details] patch
Andreas Kling
Comment 2 2013-09-09 03:33:30 PDT
Comment on attachment 211024 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=211024&action=review A+, good patch, would review again! > Source/WebCore/dom/Document.h:-546 > - // FIXME: Remove this, callers that have a Document* should call renderView(). > - // Shadow the implementations on Node to provide faster access for documents. > - RenderView* renderer() const { return m_renderView; } Thanks for fixing my FIXME! :D
Antti Koivisto
Comment 3 2013-09-09 03:36:52 PDT
https://trac.webkit.org/r155344
Darin Adler
Comment 4 2013-09-09 09:49:20 PDT
Comment on attachment 211024 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=211024&action=review > Source/WebCore/dom/Document.h:1187 > + RenderObject* renderer() const WTF_DELETED_FUNCTION; In cases like this I often just make the return type void.
Note You need to log in before you can comment on or make changes to this bug.