Bug 121026 - MouseLeave not always emitted when cursor leaves subframe
Summary: MouseLeave not always emitted when cursor leaves subframe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on: 120862
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-09 02:53 PDT by Allan Sandfeld Jensen
Modified: 2013-09-09 06:57 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.94 KB, patch)
2013-09-09 03:18 PDT, Allan Sandfeld Jensen
tonikitoo: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (516.57 KB, application/zip)
2013-09-09 06:25 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-09-09 02:53:55 PDT
I noticed the recursive calls in Document::updateHoverActiveState does not forward the PlatformMouseEvent* pointer. This means the nested frames will not have enough information to emit  mouseleave.
Comment 1 Allan Sandfeld Jensen 2013-09-09 03:18:34 PDT
Created attachment 211023 [details]
Patch
Comment 2 Build Bot 2013-09-09 06:25:46 PDT
Comment on attachment 211023 [details]
Patch

Attachment 211023 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1732374

New failing tests:
fast/events/mouseleave-on-subframe.html
Comment 3 Build Bot 2013-09-09 06:25:48 PDT
Created attachment 211034 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 4 Allan Sandfeld Jensen 2013-09-09 06:47:57 PDT
 mouseenter on DIV
 mouseenter on BODY
 mouseenter on HTML
+mouseenter on #document
 mouseleave on DIV
 mouseleave on BODY
 mouseleave on HTML
+mouseleave on #document
 

Ah, perfect. Testing bug 120862
Comment 5 Allan Sandfeld Jensen 2013-09-09 06:57:18 PDT
Committed r155348: <http://trac.webkit.org/changeset/155348>