Bug 121009 – <iframe>: The last valid content gets loaded when history navigating.

• Status: ASSIGNED
• Component: History

[alan]

1. load page with an <iframe> pointing to valid content. (existing.html)
2. change the <iframe>'s url to missing content (404) and reload the page. (missing.html)
3. navigate away from the page
4. navigate back

expected result:
iframe loads the missing.html and produces 404.

actual result:
iframe loads existing.html.

[alan]

Created attachment 210986 [details]
Patch

[alan]

The patch might be too aggressive in removing existing history items and we could do something more specific, like removing/updating only when the url change triggers the error.

HistoryItem* child = parentHistoryItem->childItemWithTarget(m_frame.tree().uniqueName());
if (child && child->url() != error.failingURL())
    parentHistoryItem->removeChildItem(child);

[Build Bot]

Comment on attachment 210986 [details]
Patch

Attachment 210986 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1733097

New failing tests:
http/tests/navigation/post-frames-goback1-uncached.html
http/tests/navigation/forward-and-cancel.html

[Build Bot]

Created attachment 210990 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 210986 [details]
Patch

Attachment 210986 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1734121

New failing tests:
http/tests/navigation/post-frames-goback1-uncached.html
http/tests/navigation/forward-and-cancel.html

[Build Bot]

Created attachment 210993 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 210986 [details]
Patch

Attachment 210986 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1728185

New failing tests:
http/tests/navigation/post-frames-goback1-uncached.html
http/tests/navigation/forward-and-cancel.html

[Build Bot]

Created attachment 210998 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[alan]

Created attachment 211558 [details]
Patch