121006 – Begin moving off of TypeTraits.h

Bug 121006 - Begin moving off of TypeTraits.h

Summary: Begin moving off of TypeTraits.h

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Template Framework (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Anders Carlsson

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-09-08 08:55 PDT by Anders Carlsson
Modified:	2013-09-10 00:00 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (24.84 KB, patch) 2013-09-08 08:58 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (24.91 KB, patch) 2013-09-08 09:07 PDT, Anders Carlsson	no flags	Details \| Formatted Diff \| Diff
Patch (24.91 KB, patch) 2013-09-09 07:47 PDT, Anders Carlsson	darin: review+	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Anders Carlsson 2013-09-08 08:55:33 PDT

Begin moving off of TypeTraits.h

Comment 1 Anders Carlsson 2013-09-08 08:58:09 PDT

Created attachment 210979 [details]
Patch

Comment 2 WebKit Commit Bot 2013-09-08 08:59:08 PDT

Attachment 210979 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/heap/PassWeak.h', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/WriteBarrier.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/CheckedArithmetic.h', u'Source/WTF/wtf/HashTraits.h', u'Source/WTF/wtf/NeverDestroyed.h', u'Source/WTF/wtf/OwnPtr.h', u'Source/WTF/wtf/PassOwnPtr.h', u'Source/WTF/wtf/RetainPtr.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h', u'Source/WebKit2/Platform/CoreIPC/Arguments.h', u'Source/WebKit2/Shared/API/c/WKSharedAPICast.h']" exit_code: 1
Source/WebKit2/Platform/CoreIPC/Arguments.h:74:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:105:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:106:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:137:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:137:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:138:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:138:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:139:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:170:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:170:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:171:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:171:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:172:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:172:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:173:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:204:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:204:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:205:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:205:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:206:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:206:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:207:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:207:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:208:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:239:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:239:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:240:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:240:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:241:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:241:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:242:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:242:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:243:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:243:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:244:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:275:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:276:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:277:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:278:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:279:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:280:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:310:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:311:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:312:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:313:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:314:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:315:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:316:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:317:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WTF/wtf/CheckedArithmetic.h:163:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 51 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Anders Carlsson 2013-09-08 09:07:18 PDT

Created attachment 210980 [details]
Patch

Comment 4 WebKit Commit Bot 2013-09-08 09:08:13 PDT

Attachment 210980 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/heap/PassWeak.h', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/WriteBarrier.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/CheckedArithmetic.h', u'Source/WTF/wtf/HashTraits.h', u'Source/WTF/wtf/NeverDestroyed.h', u'Source/WTF/wtf/OwnPtr.h', u'Source/WTF/wtf/PassOwnPtr.h', u'Source/WTF/wtf/RetainPtr.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h', u'Source/WebKit2/Platform/CoreIPC/Arguments.h', u'Source/WebKit2/Shared/API/c/WKSharedAPICast.h']" exit_code: 1
Source/WTF/wtf/PassOwnPtr.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:74:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:105:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:106:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:137:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:137:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:138:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:138:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:139:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:170:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:170:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:171:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:171:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:172:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:172:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:173:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:204:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:204:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:205:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:205:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:206:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:206:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:207:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:207:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:208:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:239:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:239:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:240:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:240:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:241:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:241:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:242:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:242:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:243:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:243:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:244:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:275:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:276:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:277:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:278:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:279:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:280:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:310:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:311:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:312:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:313:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:314:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:315:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:316:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:317:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WTF/wtf/CheckedArithmetic.h:164:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 52 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 EFL EWS Bot 2013-09-08 09:22:03 PDT

Comment on attachment 210980 [details]
Patch

Attachment 210980 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1731095

Comment 6 EFL EWS Bot 2013-09-08 09:39:29 PDT

Comment on attachment 210980 [details]
Patch

Attachment 210980 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1733052

Comment 7 Darin Adler 2013-09-08 23:41:35 PDT

Comment on attachment 210980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210980&action=review

Strange failure in the EFL port. They are using an incomplete type in some source file and somehow got away with it.

>> Source/WTF/wtf/CheckedArithmetic.h:164
>> +    template <typename Target, typename Source, bool CanElide = std::is_same<Target, Source>::value || (sizeof(Target) > sizeof(Source)) > struct BoundsCheckElider;
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

Looks like an accidental indent happened here.

Comment 8 Darin Adler 2013-09-08 23:48:57 PDT

Yup, MainThreadEfl.cpp tries to rely on a deleteOwnedPtr overload to call ecore_pipe_del on an incomplete pointer type. But this override is defined only in OwnPtrEfl.cpp and not declared in any header; these overloads are not visible in MainThreadEfl.cpp, so this doesn't work at all.

Comment 9 Anders Carlsson 2013-09-09 07:45:20 PDT

(In reply to comment #8)
> Yup, MainThreadEfl.cpp tries to rely on a deleteOwnedPtr overload to call ecore_pipe_del on an incomplete pointer type. But this override is defined only in OwnPtrEfl.cpp and not declared in any header; these overloads are not visible in MainThreadEfl.cpp, so this doesn't work at all.

Yeah, trying a different approach now.

Comment 10 Anders Carlsson 2013-09-09 07:47:09 PDT

Created attachment 211042 [details]
Patch

Comment 11 WebKit Commit Bot 2013-09-09 07:48:32 PDT

Attachment 211042 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/heap/PassWeak.h', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/WriteBarrier.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/CheckedArithmetic.h', u'Source/WTF/wtf/HashTraits.h', u'Source/WTF/wtf/NeverDestroyed.h', u'Source/WTF/wtf/OwnPtr.h', u'Source/WTF/wtf/PassOwnPtr.h', u'Source/WTF/wtf/RetainPtr.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h', u'Source/WebKit2/Platform/CoreIPC/Arguments.h', u'Source/WebKit2/Shared/API/c/WKSharedAPICast.h']" exit_code: 1
Source/WTF/wtf/PassOwnPtr.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:74:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:105:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:105:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:106:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:137:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:137:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:138:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:138:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:139:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:170:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:170:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:171:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:171:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:172:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:172:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:173:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:204:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:204:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:205:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:205:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:206:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:206:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:207:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:207:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:208:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:239:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:239:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:240:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:240:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:241:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:241:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:242:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:242:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:243:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:243:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:244:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/Platform/CoreIPC/Arguments.h:275:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:276:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:277:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:278:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:279:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:280:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:310:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:311:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:312:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:313:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:314:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:315:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:316:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit2/Platform/CoreIPC/Arguments.h:317:  std::remove_const::type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 51 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 12 Anders Carlsson 2013-09-09 10:09:25 PDT

Committed r155357: <http://trac.webkit.org/changeset/155357>

Comment 13 Mikhail Pozdnyakov 2013-09-10 00:00:51 PDT

I think https://bugs.webkit.org/show_bug.cgi?id=120630 can be treated as part of this work.