121006 – Begin moving off of TypeTraits.h

RESOLVED FIXED 121006

Begin moving off of TypeTraits.h

https://bugs.webkit.org/show_bug.cgi?id=121006

Summary Begin moving off of TypeTraits.h

Anders Carlsson

Reported 2013-09-08 08:55:33 PDT

Begin moving off of TypeTraits.h

Attachments
Patch (24.84 KB, patch) 2013-09-08 08:58 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (24.91 KB, patch) 2013-09-08 09:07 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (24.91 KB, patch) 2013-09-09 07:47 PDT, Anders Carlsson	darin: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-09-08 08:58:09 PDT

Created attachment 210979 [details] Patch

WebKit Commit Bot

Comment 2 2013-09-08 08:59:08 PDT

Attachment 210979 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/heap/PassWeak.h', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/WriteBarrier.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/CheckedArithmetic.h', u'Source/WTF/wtf/HashTraits.h', u'Source/WTF/wtf/NeverDestroyed.h', u'Source/WTF/wtf/OwnPtr.h', u'Source/WTF/wtf/PassOwnPtr.h', u'Source/WTF/wtf/RetainPtr.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h', u'Source/WebKit2/Platform/CoreIPC/Arguments.h', u'Source/WebKit2/Shared/API/c/WKSharedAPICast.h']" exit_code: 1 Source/WebKit2/Platform/CoreIPC/Arguments.h:74: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:105: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:137: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:138: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:170: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:171: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:172: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:172: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:204: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:205: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:206: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:207: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:239: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:240: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:241: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:242: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:243: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:243: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:244: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:275: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:276: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:277: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:278: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:279: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:280: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:310: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:311: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:312: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:313: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:314: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:315: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:316: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:317: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/CheckedArithmetic.h:163: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 51 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2013-09-08 09:07:18 PDT

Created attachment 210980 [details] Patch

WebKit Commit Bot

Comment 4 2013-09-08 09:08:13 PDT

Attachment 210980 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/heap/PassWeak.h', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/WriteBarrier.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/CheckedArithmetic.h', u'Source/WTF/wtf/HashTraits.h', u'Source/WTF/wtf/NeverDestroyed.h', u'Source/WTF/wtf/OwnPtr.h', u'Source/WTF/wtf/PassOwnPtr.h', u'Source/WTF/wtf/RetainPtr.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h', u'Source/WebKit2/Platform/CoreIPC/Arguments.h', u'Source/WebKit2/Shared/API/c/WKSharedAPICast.h']" exit_code: 1 Source/WTF/wtf/PassOwnPtr.h:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:74: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:105: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:137: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:138: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:170: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:171: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:172: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:172: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:204: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:205: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:206: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:207: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:239: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:240: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:241: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:242: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:243: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:243: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:244: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:275: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:276: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:277: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:278: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:279: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:280: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:310: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:311: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:312: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:313: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:314: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:315: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:316: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:317: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/CheckedArithmetic.h:164: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 52 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 5 2013-09-08 09:22:03 PDT

Comment on attachment 210980 [details] Patch Attachment 210980 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1731095

EFL EWS Bot

Comment 6 2013-09-08 09:39:29 PDT

Comment on attachment 210980 [details] Patch Attachment 210980 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1733052

Darin Adler

Comment 7 2013-09-08 23:41:35 PDT

Comment on attachment 210980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210980&action=review Strange failure in the EFL port. They are using an incomplete type in some source file and somehow got away with it. >> Source/WTF/wtf/CheckedArithmetic.h:164 >> + template <typename Target, typename Source, bool CanElide = std::is_same<Target, Source>::value || (sizeof(Target) > sizeof(Source)) > struct BoundsCheckElider; > > Code inside a namespace should not be indented. [whitespace/indent] [4] Looks like an accidental indent happened here.

Darin Adler

Comment 8 2013-09-08 23:48:57 PDT

Yup, MainThreadEfl.cpp tries to rely on a deleteOwnedPtr overload to call ecore_pipe_del on an incomplete pointer type. But this override is defined only in OwnPtrEfl.cpp and not declared in any header; these overloads are not visible in MainThreadEfl.cpp, so this doesn't work at all.

Anders Carlsson

Comment 9 2013-09-09 07:45:20 PDT

(In reply to comment #8) > Yup, MainThreadEfl.cpp tries to rely on a deleteOwnedPtr overload to call ecore_pipe_del on an incomplete pointer type. But this override is defined only in OwnPtrEfl.cpp and not declared in any header; these overloads are not visible in MainThreadEfl.cpp, so this doesn't work at all. Yeah, trying a different approach now.

Anders Carlsson

Comment 10 2013-09-09 07:47:09 PDT

Created attachment 211042 [details] Patch

WebKit Commit Bot

Comment 11 2013-09-09 07:48:32 PDT

Attachment 211042 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/heap/PassWeak.h', u'Source/JavaScriptCore/runtime/JSCell.h', u'Source/JavaScriptCore/runtime/WriteBarrier.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/CheckedArithmetic.h', u'Source/WTF/wtf/HashTraits.h', u'Source/WTF/wtf/NeverDestroyed.h', u'Source/WTF/wtf/OwnPtr.h', u'Source/WTF/wtf/PassOwnPtr.h', u'Source/WTF/wtf/RetainPtr.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentCoders.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentDecoder.h', u'Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h', u'Source/WebKit2/Platform/CoreIPC/Arguments.h', u'Source/WebKit2/Shared/API/c/WKSharedAPICast.h']" exit_code: 1 Source/WTF/wtf/PassOwnPtr.h:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:74: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:105: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:105: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:137: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:137: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:138: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:139: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:170: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:170: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:171: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:172: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:172: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:204: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:204: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:205: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:205: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:206: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:206: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:207: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:207: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:208: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:239: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:239: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:240: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:240: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:241: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:242: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:243: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:243: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:244: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit2/Platform/CoreIPC/Arguments.h:275: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:276: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:277: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:278: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:279: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:280: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:310: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:311: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:312: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:313: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:314: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:315: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:316: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebKit2/Platform/CoreIPC/Arguments.h:317: std::remove_const::type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 51 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 12 2013-09-09 10:09:25 PDT

Committed r155357: <http://trac.webkit.org/changeset/155357>

Mikhail Pozdnyakov

Comment 13 2013-09-10 00:00:51 PDT

I think https://bugs.webkit.org/show_bug.cgi?id=120630 can be treated as part of this work.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component Web Template Framework

Assignee

Anders Carlsson

Reported

2013-09-08 08:55 PDT

Modified

2013-09-10 00:00 PDT History

CC List

7 users Show

URL

Keywords

Depends on

Blocks