Bug 121005 - Rename needsShadowTreeWalker
Summary: Rename needsShadowTreeWalker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-08 03:54 PDT by Antti Koivisto
Modified: 2013-09-08 04:29 PDT (History)
4 users (show)

See Also:


Attachments
patch (12.10 KB, patch)
2013-09-08 04:02 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-08 03:54:20 PDT
There is no ShadowTreeWalker.
Comment 1 Antti Koivisto 2013-09-08 04:02:43 PDT
Created attachment 210976 [details]
patch
Comment 2 Andreas Kling 2013-09-08 04:22:28 PDT
Comment on attachment 210976 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210976&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        Renemane to needsNodeRenderingTraversalSlowPath.

typo

> Source/WebCore/dom/Element.cpp:1422
> +    setNeedsNodeRenderingTraversalSlowPath(determineNeedsNodeRenderingTraversalSlowPath(*this));

This is so long I can't read the whole line without blinking.
I don't have any better suggestions right now though :(
Comment 3 Antti Koivisto 2013-09-08 04:29:36 PDT
https://trac.webkit.org/r155303