Bug 120983 - gtest fails to build due to integer type mismatch in WTF::insertIntoBoundedVector()
Summary: gtest fails to build due to integer type mismatch in WTF::insertIntoBoundedVe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-07 18:02 PDT by David Kilzer (:ddkilzer)
Modified: 2013-09-07 20:45 PDT (History)
9 users (show)

See Also:


Attachments
Patch v1 (1.68 KB, patch)
2013-09-07 18:07 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2013-09-07 18:02:55 PDT
When gtest builds for the Debug configuration, I see the following error:

WebKitBuild/Debug/usr/local/include/wtf/StdLibExtras.h:266:23: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
for (unsigned i = size; i-- > index + 1;)
              ~   ^~~~
1 error generated.
Comment 1 David Kilzer (:ddkilzer) 2013-09-07 18:07:22 PDT
Created attachment 210941 [details]
Patch v1
Comment 2 WebKit Commit Bot 2013-09-07 20:45:23 PDT
Comment on attachment 210941 [details]
Patch v1

Clearing flags on attachment: 210941

Committed r155280: <http://trac.webkit.org/changeset/155280>
Comment 3 WebKit Commit Bot 2013-09-07 20:45:26 PDT
All reviewed patches have been landed.  Closing bug.