Bug 120959 - VectorMover should use std::move
Summary: VectorMover should use std::move
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-07 11:06 PDT by Anders Carlsson
Modified: 2013-09-07 17:25 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.78 KB, patch)
2013-09-07 11:08 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (4.14 KB, patch)
2013-09-07 12:23 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-09-07 11:06:10 PDT 
VectorMover should use std::move
Comment 1 Anders Carlsson 2013-09-07 11:08:01 PDT 
Created attachment 210913 [details]
Patch
Comment 2 Early Warning System Bot 2013-09-07 11:16:50 PDT 
Comment on attachment 210913 [details]
Patch

Attachment 210913 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1723005
Comment 3 Early Warning System Bot 2013-09-07 11:20:17 PDT 
Comment on attachment 210913 [details]
Patch

Attachment 210913 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1703996
Comment 4 Geoffrey Garen 2013-09-07 11:41:13 PDT 
/home/webkit/WebKit/Source/JavaScriptCore/bytecode/CallLinkInfo.h:45:8: error: invalid conversion from 'unsigned char:5' to 'JSC::CallLinkInfo::CallType' [-fpermissive]

I guess this means that the Qt compiler needs an explicit move constructor for CallLinkInfo, since it isn't willing to implicitly copy a typed bitfield?
Comment 5 Geoffrey Garen 2013-09-07 11:41:29 PDT 
Comment on attachment 210913 [details]
Patch

r=me
Comment 6 Anders Carlsson 2013-09-07 11:54:29 PDT 
(In reply to comment #4)
> /home/webkit/WebKit/Source/JavaScriptCore/bytecode/CallLinkInfo.h:45:8: error: invalid conversion from 'unsigned char:5' to 'JSC::CallLinkInfo::CallType' [-fpermissive]
> 
> I guess this means that the Qt compiler needs an explicit move constructor for CallLinkInfo, since it isn't willing to implicitly copy a typed bitfield?

I think it’s a bug in that particular version of GCC. I am going to change the bitfield type to unsigned instead.
Comment 7 Anders Carlsson 2013-09-07 12:23:39 PDT 
Created attachment 210916 [details]
Patch
Comment 8 Anders Carlsson 2013-09-07 12:45:05 PDT 
Committed r155258: <http://trac.webkit.org/changeset/155258>