Bug 120904 - Remove fastNew/fastDelete
Summary: Remove fastNew/fastDelete
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-06 15:54 PDT by Anders Carlsson
Modified: 2013-09-06 16:07 PDT (History)
8 users (show)

See Also:


Attachments
Patch (11.73 KB, patch)
2013-09-06 15:55 PDT, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-09-06 15:54:28 PDT
Remove fastNew/fastDelete
Comment 1 Anders Carlsson 2013-09-06 15:55:41 PDT
Created attachment 210810 [details]
Patch
Comment 2 Andreas Kling 2013-09-06 15:59:29 PDT
Comment on attachment 210810 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210810&action=review

r=me, so much tasty redness!

> Source/WebCore/css/CSSSelectorList.cpp:75
> +                // Free the underlying memory without invoking the destructor.
> +                operator delete (currentSelector);

This is so ugly it hurts.
Comment 3 Anders Carlsson 2013-09-06 16:07:44 PDT
Committed r155221: <http://trac.webkit.org/changeset/155221>