Bug 120892 - [WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null
Summary: [WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() ret...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alberto Garcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-06 13:21 PDT by Alberto Garcia
Modified: 2013-09-11 09:14 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.59 KB, patch)
2013-09-06 13:24 PDT, Alberto Garcia
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-09-06 13:21:59 PDT
This is a follow-up to bug 117733.

If the glContext() call in LayerTreeHostGtk::initialize() returns
null, m_isValid is set to false, which breaks an assertion in
invalidate().

It's not necessary to set m_isValid here, the rest of the code already
deals with the case where glContext() is null so that can be safely
removed.

The m_isValid variable is otherwise relevant in this class since it
checks that invalidate() is called once before the object is
destroyed.
Comment 1 Alberto Garcia 2013-09-06 13:24:37 PDT
Created attachment 210789 [details]
Patch
Comment 2 Alberto Garcia 2013-09-11 09:14:40 PDT
Committed r155533: <http://trac.webkit.org/changeset/155533>