RESOLVED FIXED 120882
MediaStream API: Storing the constraints in MediaStreamSource 
https://bugs.webkit.org/show_bug.cgi?id=120882
Summary MediaStream API: Storing the constraints in MediaStreamSource
Eric Carlson
Reported 2013-09-06 12:36:41 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/04ac7655b54ae98f55774afde3f8e92b6c6302e6 It was requested that the constraints object, if any, should be stored in the source for later referencing. The first user of this is WebAudio but for consistency the video constraints are stored as well.
Attachments
Patch (3.29 KB, patch)
2013-09-14 15:26 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Patch (3.33 KB, patch)
2013-09-16 07:07 PDT, Thiago de Barros Lacerda 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago de Barros Lacerda
Comment 1 2013-09-14 15:26:38 PDT
Created attachment 211669 [details] Patch
Eric Carlson
Comment 2 2013-09-14 16:15:41 PDT
Comment on attachment 211669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211669&action=review > Source/WebCore/ChangeLog:8 > + No new tests needed. Please note the Blink revision this was merged from. > Source/WebCore/Modules/mediastream/UserMediaRequest.cpp:150 > + (*iter)->component()->source()->setConstraints(m_audio); > + > + > + MediaStreamTrackVector videoTracks = stream->getVideoTracks(); Nit: you have an extra blank line here.
Thiago de Barros Lacerda
Comment 3 2013-09-16 07:07:02 PDT
Created attachment 211779 [details] Patch
Thiago de Barros Lacerda
Comment 4 2013-09-16 07:08:17 PDT
Removed extra line and removed unnecessary vector creation inside UserMediaRequest::succeed method
WebKit Commit Bot
Comment 5 2013-09-16 10:20:30 PDT
Comment on attachment 211779 [details] Patch Clearing flags on attachment: 211779 Committed r155881: <http://trac.webkit.org/changeset/155881>
WebKit Commit Bot
Comment 6 2013-09-16 10:20:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.