Consider merging https://chromium.googlesource.com/chromium/blink/+/621822b20d5b0ceceb000b3c02ae82cce5063c51 This change allows binding intergrity checks to be applied to these obects.
Created attachment 211241 [details] Proposed patch
Comment on attachment 211241 [details] Proposed patch LGTM. r=me.
I'm not against this change, but I don't follow the reasoning. What about making them ScriptWrappable helps with the integrity checks. I think the only thing needed for those checks is a vtable.
I'd like Oliver to comment before landing.
Looks good
Comment on attachment 211241 [details] Proposed patch Clearing flags on attachment: 211241 Committed r155478: <http://trac.webkit.org/changeset/155478>
All reviewed patches have been landed. Closing bug.
(In reply to comment #5) > Looks good Oliver, what about making them ScriptWrappable helps with the integrity checks?
(In reply to comment #8) > (In reply to comment #5) > > Looks good > > Oliver, what about making them ScriptWrappable helps with the integrity checks? I talked to Geoff about this patch before I posted it. He said that with JSC it won't help with "binding integrity checks", but that it I might as well merge it to make future merges easier. The "This change allows binding intergrity checks to be applied to these obects" comment is from the blink bug. I didn't include it in the ChangeLog.