Bug 120878 - Split MediaStreamDescriptor.h and MediaStreamComponent.h into .h and .cpp
Summary: Split MediaStreamDescriptor.h and MediaStreamComponent.h into .h and .cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 121101
  Show dependency tree / graph
 
Reported: 2013-09-06 11:57 PDT by Eric Carlson
Modified: 2013-09-11 09:13 PDT (History)
11 users (show)

See Also:

Attachments
Proposed patch (24.06 KB, patch)
2013-09-10 13:20 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch (24.18 KB, patch)
2013-09-10 13:33 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Include new files in CMakeLists.txt (24.82 KB, patch)
2013-09-10 13:58 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-09-06 11:57:24 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/270b07c899154510d539c7e1d2e0411be46c257a 

What one were two simple classes have grown and now needs a split into a header
and a implementation file. These files will go through some work soon as well.
Comment 1 Eric Carlson 2013-09-10 13:20:00 PDT 
Created attachment 211231 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2013-09-10 13:22:00 PDT 
Attachment 211231 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/LocalMediaStream.cpp', u'Source/WebCore/Modules/mediastream/MediaStream.cpp', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/platform/mediastream/MediaStreamComponent.cpp', u'Source/WebCore/platform/mediastream/MediaStreamComponent.h', u'Source/WebCore/platform/mediastream/MediaStreamDescriptor.cpp', u'Source/WebCore/platform/mediastream/MediaStreamDescriptor.h']" exit_code: 1
Source/WebCore/platform/mediastream/MediaStreamDescriptor.h:62:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2013-09-10 13:33:17 PDT 
Created attachment 211232 [details]
Updated patch
Comment 4 Sergio Correia (qrwteyrutiyoup) 2013-09-10 13:44:34 PDT 
Maybe add MediaStreamComponent.cpp and MediaStreamDescriptor.cpp to Source/WebCore/CMakeLists as well?
Comment 5 Eric Carlson 2013-09-10 13:58:43 PDT 
Created attachment 211238 [details]
Include new files in CMakeLists.txt
Comment 6 Jer Noble 2013-09-10 14:01:48 PDT 
Comment on attachment 211238 [details]
Include new files in CMakeLists.txt

LGTM. r=me.
Comment 7 WebKit Commit Bot 2013-09-10 14:41:00 PDT 
Comment on attachment 211238 [details]
Include new files in CMakeLists.txt

Clearing flags on attachment: 211238

Committed r155477: <http://trac.webkit.org/changeset/155477>
Comment 8 WebKit Commit Bot 2013-09-10 14:41:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Sergio Correia (qrwteyrutiyoup) 2013-09-10 15:08:17 PDT 
(In reply to comment #5)
> Created an attachment (id=211238) [details]
> Include new files in CMakeLists.txt

The files were included in the CMakeList.txt with a wrong path, and caused build problems in EFL :)

I submitted https://bugs.webkit.org/show_bug.cgi?id=121126 to fix it.
Comment 10 Eric Carlson 2013-09-11 09:13:07 PDT 
(In reply to comment #9)
> (In reply to comment #5)
> > Created an attachment (id=211238) [details] [details]
> > Include new files in CMakeLists.txt
> 
> The files were included in the CMakeList.txt with a wrong path, and caused build problems in EFL :)
> 
  Sorry about that :-(

> I submitted https://bugs.webkit.org/show_bug.cgi?id=121126 to fix it.
>
  Thanks!