Bug 120875 – MediaStream API: Remove LocalMediaStream

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Eric Carlson]

Consider merging https://chromium.googlesource.com/chromium/blink/+/81643ee3fe048a64fa8931132e1294fa2c8e821a 

The subclass LocalMediaStream have been removed from the getusermedia specification:
http://dev.w3.org/2011/webrtc/editor/getusermedia.html

The stop method will be moved temporarily to MediaStream until MediaStreamTrack has been updated.

[Thiago de Barros Lacerda]

Created attachment 211275 [details]
Patch

[Build Bot]

Comment on attachment 211275 [details]
Patch

Attachment 211275 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1736748

[Build Bot]

Comment on attachment 211275 [details]
Patch

Attachment 211275 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1731829

[kov's GTK+ EWS bot]

Comment on attachment 211275 [details]
Patch

Attachment 211275 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1743456

[Thiago de Barros Lacerda]

Created attachment 211334 [details]
Patch

[Eric Carlson]

Comment on attachment 211334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211334&action=review

r=me with the changes noted.

> Source/WebCore/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=120875
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Existing tests were updated.

This should reference the Blink change this was merged from.

> Source/WebCore/Modules/mediastream/MediaStream.h:-53
> -    // DEPRECATED
> -    String label() const { return m_descriptor->id(); }
> -

This is unrelated, it should be removed in another patch.

> Source/WebCore/Modules/mediastream/MediaStream.idl:-37
> -    // DEPRECATED
> -    readonly attribute DOMString label;
> -

Ditto

[Thiago de Barros Lacerda]

Created attachment 211356 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 211356 [details]
Patch

Clearing flags on attachment: 211356

Committed r155573: <http://trac.webkit.org/changeset/155573>