Bug 120871 - MediaStream should fire ended event when all tracks are ended
Summary: MediaStream should fire ended event when all tracks are ended
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 121101
  Show dependency treegraph
 
Reported: 2013-09-06 11:44 PDT by Eric Carlson
Modified: 2013-09-10 10:30 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (14.59 KB, patch)
2013-09-06 14:14 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Updated patch, this time without already-landed-changes (11.67 KB, patch)
2013-09-06 14:33 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Patch that causes fewer regressions, AND with a complete ChangeLog! (7.61 KB, patch)
2013-09-06 14:55 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Updated patch (7.20 KB, patch)
2013-09-06 16:51 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-09-06 11:44:54 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/bebd179b65be69e46f2f434a3ec8b1e4aa85cc42

MediaStream should fire ended event when all tracks are ended
Comment 1 Eric Carlson 2013-09-06 14:14:57 PDT
Created attachment 210799 [details]
Proposed patch
Comment 2 Eric Carlson 2013-09-06 14:33:27 PDT
Created attachment 210800 [details]
Updated patch, this time without already-landed-changes
Comment 3 Eric Carlson 2013-09-06 14:55:59 PDT
Created attachment 210802 [details]
Patch that causes fewer regressions, AND with a complete ChangeLog!
Comment 4 Eric Carlson 2013-09-06 16:51:20 PDT
Created attachment 210817 [details]
Updated patch
Comment 5 Jer Noble 2013-09-06 17:52:31 PDT
Comment on attachment 210817 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210817&action=review

r=me, with nit:

> Source/WebCore/ChangeLog:4
> +        MediaStream should fire ended event when all tracks are ended
> +        https://bugs.webkit.org/show_bug.cgi?id=120871

This should include a line stating that this is a blink merge, and include the URL to the blink commit.
Comment 6 Eric Carlson 2013-09-07 08:34:26 PDT
Comment on attachment 210817 [details]
Updated patch

(In reply to comment #5)
> (From update of attachment 210817 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=210817&action=review
> 
> r=me, with nit:
> 
> > Source/WebCore/ChangeLog:4
> > +        MediaStream should fire ended event when all tracks are ended
> > +        https://bugs.webkit.org/show_bug.cgi?id=120871
> 
> This should include a line stating that this is a blink merge, and include the URL to the blink commit.

Oops, good point. 

Done.
Comment 7 Eric Carlson 2013-09-07 08:34:52 PDT
Committed r155249: https://trac.webkit.org/r155249