Bug 120865 - [mac] <progress> has rendering artifacts along the bottom
Summary: [mac] <progress> has rendering artifacts along the bottom
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-06 10:19 PDT by Tim Horton
Modified: 2013-09-10 11:35 PDT (History)
6 users (show)

See Also:

Attachments
patch (11.20 KB, patch)
2013-09-09 21:59 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch got stale (11.59 KB, patch)
2013-09-09 22:06 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-09-06 10:19:16 PDT 
<progress> doesn’t control its own height, so when we repaint it, we don’t know how much to repaint (we repaint 1em by default, but if you set a height: via CSS you can make the repaint problem worse or better).

<rdar://problem/11571240>
Comment 1 Tim Horton 2013-09-09 21:59:01 PDT 
Created attachment 211158 [details]
patch
Comment 2 WebKit Commit Bot 2013-09-09 22:00:51 PDT 
Attachment 211158 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/fast/forms/indeterminate-progress-inline-height-expected.txt', u'LayoutTests/platform/mac/fast/forms/indeterminate-progress-inline-height.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderTheme.h', u'Source/WebCore/rendering/RenderThemeMac.h', u'Source/WebCore/rendering/RenderThemeMac.mm']" exit_code: 1
Source/WebCore/rendering/RenderProgress.h:50:  The parameter name "computedValues" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2013-09-09 22:06:03 PDT 
Created attachment 211159 [details]
patch got stale
Comment 4 Tim Horton 2013-09-10 11:35:08 PDT 
http://trac.webkit.org/changeset/155460