120848 – [Qt] fast/regions/overflow* converted reftests failing after r155114

Bug 120848 - [Qt] fast/regions/overflow* converted reftests failing after r155114

Summary: [Qt] fast/regions/overflow* converted reftests failing after r155114

Status:	RESOLVED INVALID

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Mihai Maerean

URL:
Keywords:

Depends on:
Blocks:	120760
	Show dependency tree / graph

Reported:	2013-09-06 05:17 PDT by Zoltan Arvai
Modified:	2013-10-22 05:08 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Qt imagediffs (46.03 KB, application/zip) 2013-09-06 05:17 PDT, Zoltan Arvai	no flags	Details
patch (7.79 KB, patch) 2013-09-09 06:35 PDT, Mihai Maerean	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Zoltan Arvai 2013-09-06 05:17:06 PDT

It seems converting pixel tests to ref tests has some problems.

http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r155181%20%2830373%29/results.html

+fast/regions/overflow-in-variable-width-regions.html
+fast/regions/overflow-moving-below-floats-in-variable-width-regions.html
+fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html
+fast/regions/overflow-rtl-in-variable-width-regions.html
+fast/regions/overflow-size-change-in-variable-width-regions.html

Imagediffs are attached.

Comment 1 Zoltan Arvai 2013-09-06 05:17:58 PDT

Created attachment 210720 [details]
Qt imagediffs

Comment 2 Mihai Maerean 2013-09-09 06:35:42 PDT

Created attachment 211035 [details]
patch

Comment 3 WebKit Commit Bot 2013-09-09 07:29:47 PDT

Comment on attachment 211035 [details]
patch

Clearing flags on attachment: 211035

Committed r155350: <http://trac.webkit.org/changeset/155350>

Comment 4 WebKit Commit Bot 2013-09-09 07:29:50 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Ádám Kallai 2013-09-10 01:08:55 PDT

These tests are still failing on Qt.

* fast/regions/overflow-in-variable-width-regions.html

Diff is here:
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r155414%20(30421)/fast/regions/overflow-in-variable-width-regions-diffs.html

* fast/regions/overflow-moving-below-floats-in-variable-width-regions.html

Diff is here:
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r155414%20(30421)/fast/regions/overflow-moving-below-floats-in-variable-width-regions-diffs.html

* fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html

Diff is here:
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r155414%20(30421)/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-diffs.html

* fast/regions/overflow-rtl-in-variable-width-regions.html

Diff is here:
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r155414%20(30421)/fast/regions/overflow-rtl-in-variable-width-regions-diffs.html

* fast/regions/overflow-size-change-in-variable-width-regions.html

Diff is here:
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Debug/r155414%20(30421)/fast/regions/overflow-size-change-in-variable-width-regions-diffs.html

Comment 6 Ádám Kallai 2013-09-13 02:40:10 PDT

Skipped in http://trac.webkit.org/changeset/155679.
Please unskip with the proper fix.

Comment 7 Mihai Balan 2013-10-22 05:08:44 PDT

Qt is no more