Bug 120835 - [GTK] TestWebKitWebView::custom-charset test fails under DEBUG
Summary: [GTK] TestWebKitWebView::custom-charset test fails under DEBUG
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 117689
  Show dependency treegraph
Reported: 2013-09-06 02:46 PDT by Brian Holt
Modified: 2017-03-11 11:04 PST (History)
1 user (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Brian Holt 2013-09-06 02:46:13 PDT
An assertion failure occurs in the HistoryController when running the custom-charset test.

../../Source/WebCore/loader/HistoryController.cpp(116) : void WebCore::HistoryController::restoreScrollPositionAndViewState()
1   0x7ff62fa93254 /home/WebKit/WebKitBuild/Debug/.libs/libjavascriptcoregtk-3.0.so.0(WTFCrash+0x1e) [0x7ff62fa93254]

which happens because in Source/WebCore/loader/FrameLoader.cpp:2170 
m_loadType == FrameLoadTypeReload is true, calling history()->restoreScrollPositionAndViewState();

https://bugs.webkit.org/show_bug.cgi?id=117689#c7 is helpful:
My 2 cents here: the problem occurs after reloading of the test page. In testWebViewCustomCharset webkit_web_view_set_custom_charset(test->m_webView, "utf8"); will trigger reload of the page. Since it is asynchronous operation at some point later other test will assert in void WebCore::HistoryController::restoreScrollPositionAndViewState(). (if you add test->waitUntilLoadFinished(); next line after webkit_web_view_set_custom_charset(test->m_webView, "utf8"); it will assert in the current test). Did anybody else come across this problem before? As for r150890 change - don't think it it is directly related to this problem - may be timing has changed or something like that.