RESOLVED FIXED 120830
FrameLoader::subframeLoader() should return a reference. 
https://bugs.webkit.org/show_bug.cgi?id=120830
Summary FrameLoader::subframeLoader() should return a reference.
Andreas Kling
Reported Friday, September 6, 2013 8:15:42 AM UTC
FrameLoader::subresourceLoader() should return a reference.
Attachments
Patch (24.43 KB, patch)
2013-09-06 00:16 PDT, Andreas Kling 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (26.66 KB, patch)
2013-09-06 08:51 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 Friday, September 6, 2013 8:16:10 AM UTC
Created attachment 210708 [details] Patch
EFL EWS Bot
Comment 2 Friday, September 6, 2013 8:24:27 AM UTC
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1705280
Early Warning System Bot
Comment 3 Friday, September 6, 2013 8:25:44 AM UTC
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1706296
Early Warning System Bot
Comment 4 Friday, September 6, 2013 8:25:53 AM UTC
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1706295
EFL EWS Bot
Comment 5 Friday, September 6, 2013 8:30:07 AM UTC
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1696996
Build Bot
Comment 6 Friday, September 6, 2013 8:58:36 AM UTC
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1714099
kov's GTK+ EWS bot
Comment 7 Friday, September 6, 2013 10:15:18 AM UTC
Comment on attachment 210708 [details] Patch Attachment 210708 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1717017
Andreas Kling
Comment 8 Friday, September 6, 2013 4:51:14 PM UTC
Created attachment 210759 [details] Patch
WebKit Commit Bot
Comment 9 Friday, September 6, 2013 6:22:03 PM UTC
Comment on attachment 210759 [details] Patch Clearing flags on attachment: 210759 Committed r155194: <http://trac.webkit.org/changeset/155194>
WebKit Commit Bot
Comment 10 Friday, September 6, 2013 6:22:06 PM UTC
All reviewed patches have been landed. Closing bug.
Andreas Kling
Comment 11 Friday, September 6, 2013 8:57:09 PM UTC
Ehrm, this was about SubframeLoader, not SubresourceLoader. Brain farts aplenty.
Note You need to log in before you can comment on or make changes to this bug.