Bug 120829 - Allow string as image reference on filter()
Summary: Allow string as image reference on filter()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-05 22:59 PDT by Dirk Schulze
Modified: 2013-09-06 00:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.84 KB, patch)
2013-09-05 23:04 PDT, Dirk Schulze 		kling: review+
Details | Formatted Diff | Diff
Patch (10.86 KB, patch)
2013-09-05 23:30 PDT, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2013-09-05 22:59:11 PDT 
Beside <image> (which already includes url(), gradients, cross-fade() and image-set()), the filter() image function should support <string> as image reference.
Comment 1 Dirk Schulze 2013-09-05 23:04:23 PDT 
Created attachment 210705 [details]
Patch
Comment 2 Andreas Kling 2013-09-05 23:13:17 PDT 
Comment on attachment 210705 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210705&action=review

r=me

> Source/WebCore/css/CSSParser.cpp:8092
> +    if (!a)

This is a terrible variable name.
Comment 3 Dirk Schulze 2013-09-05 23:30:45 PDT 
Created attachment 210706 [details]
Patch
Comment 4 WebKit Commit Bot 2013-09-06 00:01:39 PDT 
Comment on attachment 210706 [details]
Patch

Clearing flags on attachment: 210706

Committed r155179: <http://trac.webkit.org/changeset/155179>
Comment 5 WebKit Commit Bot 2013-09-06 00:01:42 PDT 
All reviewed patches have been landed.  Closing bug.