Left these out previously. They've now been implemented and function properly.
<rdar://problem/14925242>
Created attachment 210692 [details] patch
Comment on attachment 210692 [details] patch Attachment 210692 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1707194 New failing tests: media/video-object-fit.html
Created attachment 210696 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
(In reply to comment #4) > Created an attachment (id=210696) [details] > Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4 This patch does not affect mac in the slightest. Flaky test.
Comment on attachment 210692 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=210692&action=review A couple of minor typos. Please fix when landing. > Source/WebKit/win/AccessibleTextImpl.cpp:-206 > - return E_NOTIMPL; Don't we need to make sure startOffset and endOffset are non-null, and return E_POINTER if they are? > Source/WebKit/win/AccessibleTextImpl.cpp:209 > + if (offset < 0 && offset > m_object->text().length()) Shouldn't this be an ||? I don't know if too man things that are negative and also larger than the text length! :) > Source/WebKit/win/AccessibleTextImpl.cpp:215 > + int previousPos = std::max(0, (int)(offset-1)); Please use a C++ cast. > Source/WebKit/win/AccessibleTextImpl.cpp:256 > + *text = SysAllocStringLen(substringText.characters(), substringText.length()); On - we should check that text is also a valid pointer passed to the function? > Source/WebKit/win/AccessibleTextImpl.cpp:271 > + if (offset < 0 && offset > textLength) These two cases are exclusive; use || > Source/WebKit/win/AccessibleTextImpl.cpp:311 > + *endOffset = textRange.end.deepEquivalent().offsetInContainerNode(); Check locations and return E_POINTER if they are not valid. > Source/WebKit/win/AccessibleTextImpl.cpp:317 > + *text = SysAllocStringLen(substringText.characters(), substringText.length()); Ditto for text. > Source/WebKit/win/AccessibleTextImpl.cpp:333 > + if (offset < 0 && offset > textLength) || please.
Committed with changes above: http://trac.webkit.org/changeset/155212