Bug 120805 – Implement Vector::append for move-only types

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Implement Vector::append for move-only types

[Anders Carlsson]

Created attachment 210674 [details]
Patch

[WebKit Commit Bot]

Attachment 210674 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Vector.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Vector.cpp']" exit_code: 1
Source/WTF/wtf/Vector.h:641:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/Vector.h:683:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 210674 [details]
Patch

Attachment 210674 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1710066

[Early Warning System Bot]

Comment on attachment 210674 [details]
Patch

Attachment 210674 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1696860

[Anders Carlsson]

Created attachment 210683 [details]
Patch

[WebKit Commit Bot]

Attachment 210683 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/bytecode/CallLinkInfo.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Vector.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Vector.cpp']" exit_code: 1
Source/WTF/wtf/Vector.h:641:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/Vector.h:683:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 210683 [details]
Patch

Attachment 210683 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1710099

[Anders Carlsson]

Created attachment 210686 [details]
Patch

[WebKit Commit Bot]

Attachment 210686 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/bytecode/CallLinkInfo.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Vector.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Vector.cpp']" exit_code: 1
Source/WTF/wtf/Vector.h:641:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/Vector.h:683:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Thanks a lot GCC...

[Early Warning System Bot]

Comment on attachment 210686 [details]
Patch

Attachment 210686 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1713049

[Early Warning System Bot]

Comment on attachment 210686 [details]
Patch

Attachment 210686 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1711083

[Darin Adler]

Comment on attachment 210686 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210686&action=review

internal compiler error on Qt?

> Source/WTF/ChangeLog:15
> +        (WTF::::expandCapacity):

Bad change log script didn’t include the class name. I add it by hand, but you could fix the script instead if you like ;-)

> Source/WTF/ChangeLog:18
> +        (WTF::::append):

Ditto.

> Source/WTF/ChangeLog:22
> +        (WTF::::appendSlowCase):

Ditto.

> Source/JavaScriptCore/bytecode/CallLinkInfo.h:85
> -    CallType callType : 5;
> +    unsigned callType : 5;

Unrelated change.

[EFL EWS Bot]

Comment on attachment 210686 [details]
Patch

Attachment 210686 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1708212

[EFL EWS Bot]

Comment on attachment 210686 [details]
Patch

Attachment 210686 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1708211

[kov's GTK+ EWS bot]

Comment on attachment 210686 [details]
Patch

Attachment 210686 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1708220

[Build Bot]

Comment on attachment 210686 [details]
Patch

Attachment 210686 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1708218

New failing tests:
fast/workers/termination-with-port-messages.html

[Build Bot]

Created attachment 210701 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 210686 [details]
Patch

Attachment 210686 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1704330

[Anders Carlsson]

Created attachment 211153 [details]
Patch

[WebKit Commit Bot]

Attachment 211153 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Vector.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Vector.cpp']" exit_code: 1
Source/WTF/wtf/Vector.h:644:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/Vector.h:686:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 211153 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211153&action=review

> Source/WTF/ChangeLog:9
> +        (WTF::::expandCapacity):

Should fill in the word Vector here. The script doesn’t get it right, but no reason to leave it bad here.

[Early Warning System Bot]

Comment on attachment 211153 [details]
Patch

Attachment 211153 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1737382

[Early Warning System Bot]

Comment on attachment 211153 [details]
Patch

Attachment 211153 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1735462

[EFL EWS Bot]

Comment on attachment 211153 [details]
Patch

Attachment 211153 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1728609

[Anders Carlsson]

Created attachment 211160 [details]
Patch

[WebKit Commit Bot]

Attachment 211160 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Vector.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Vector.cpp']" exit_code: 1
Source/WTF/wtf/Vector.h:644:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/Vector.h:686:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 211160 [details]
Patch

Attachment 211160 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1762003

New failing tests:
compositing/backface-visibility/backface-visibility-hierarchical-transform.html
compositing/absolute-inside-out-of-view-fixed.html
animations/3d/matrix-transform-type-animation.html
animations/3d/state-at-end-event-transform.html
animations/added-while-suspended.html
animations/animation-add-events-in-handler.html
animations/additive-transform-animations.html
animations/3d/replace-filling-transform.html
accessibility/accessibility-object-detached.html
compositing/backface-visibility/backface-visibility-3d.html
accessibility/accessibility-node-reparent.html
http/tests/appcache/abort-cache-onchecking-resource-404.html
compositing/animation/animation-compositing.html
canvas/philip/tests/2d.canvas.readonly.html
compositing/animation/computed-style-during-delay.html
animations/3d/change-transform-in-end-event.html
compositing/animation/busy-indicator.html
compositing/absolute-position-changed-in-composited-layer.html
compositing/bounds-in-flipped-writing-mode.html
compositing/animation/animated-composited-inside-hidden.html
http/tests/appcache/abort-cache-onchecking-manifest-404.html
canvas/philip/tests/2d.canvas.reference.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
animations/3d/transform-origin-vs-functions.html
accessibility/accessibility-node-memory-management.html
compositing/backface-visibility/backface-visibility-image.html
compositing/backface-visibility/backface-visibility-non3d.html
http/tests/appcache/404-manifest.html
http/tests/appcache/404-resource.html
compositing/absolute-position-changed-with-composited-parent-layer.html

[Build Bot]

Created attachment 211181 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Anders Carlsson]

Created attachment 211320 [details]
Patch

[WebKit Commit Bot]

Attachment 211320 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Vector.h', u'Tools/ChangeLog', u'Tools/TestWebKitAPI/Tests/WTF/Vector.cpp']" exit_code: 1
Source/WTF/wtf/Vector.h:643:  Missing spaces around &&  [whitespace/operators] [3]
Source/WTF/wtf/Vector.h:685:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Committed r155541: <http://trac.webkit.org/changeset/155541>