RESOLVED FIXED Bug 120804
Web Inspector: Edit Breakpoint popover sometimes appears misplaced in top left 
https://bugs.webkit.org/show_bug.cgi?id=120804
Summary Web Inspector: Edit Breakpoint popover sometimes appears misplaced in top left
Joseph Pecoraro
Reported 2013-09-05 15:37:25 PDT
Occasionally the Edit Breakpoint popover is poorly sized and misplaced in the top left. This looks really bad! * STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com/shell/> 2. Set a breakpoint on easySlider.min.js:3 3. Edit Breakpoint + set autoContinue 4. Close and reopen inspector (to save changes) 5. Reload page (⌘R) 6. Select breakpoint in sidebar 7. Choose Edit Breakpoint either in the Sidebar or Gutter NOTE: Repeat steps 5-7 as needed till you reproduce => misplaced popover
Attachments
[PATCH] Proposed Fix (2.48 KB, patch)
2013-09-05 15:40 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-09-05 15:37:50 PDT
After some debugging, this appears to happen when the element that is the contextmenu event's targetElement is no longer in the DOM by the time we call getBoundingClientRect. So we can grab the bounding client rect earlier, and not carry the element around.
Radar WebKit Bug Importer
Comment 2 2013-09-05 15:37:52 PDT
<rdar://problem/14923517>
Joseph Pecoraro
Comment 3 2013-09-05 15:40:59 PDT
Created attachment 210672 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 4 2013-09-05 17:54:42 PDT
Comment on attachment 210672 [details] [PATCH] Proposed Fix Clearing flags on attachment: 210672 Committed r155165: <http://trac.webkit.org/changeset/155165>
WebKit Commit Bot
Comment 5 2013-09-05 17:54:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.